fillNodes overwrites the layout and children properties #62

New Issue

2015-03-26T09:59:19-07:00

esprehn commented

2015-03-26 09:59:19 -07:00

(Migrated from github.com)

If node already has a layout object it should leave it alone, this just means allocating new Rect like objects each time this is called even if layout has been done before.

Also if you define node.style.measure it clears the children property, but that's bad if the measure function wanted to be able to look at the children or call layout on them.

If node already has a layout object it should leave it alone, this just means allocating new Rect like objects each time this is called even if layout has been done before. Also if you define node.style.measure it clears the children property, but that's bad if the measure function wanted to be able to look at the children or call layout on them.

vjeux commented

2015-06-04 12:24:34 -07:00

(Migrated from github.com)

Please feel free to send a pull request for this :) The js version has not been designed with performance in mind, only the C one

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#62