DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix min/max percentage constraints on measured nodes #649

Closed
woehrl01 wants to merge 1 commits from percentage_nested into master
pull from: percentage_nested
merge into: DaddyFrosty:master
Conversation 3 Commits 1 Files Changed 2 +57 -4
woehrl01 commented 2017-10-09 11:10:51 -07:00 (Migrated from github.com)
Copy Link

Fix min/max percentage constraints on measured nodes. Currently we passed in the available size instead of the parent size.
Fixes #611

Fix min/max percentage constraints on measured nodes. Currently we passed in the available size instead of the parent size. Fixes #611
woehrl01 commented 2017-10-09 11:24:29 -07:00 (Migrated from github.com)
Copy Link

Just also fixed the case where we have percentage values as padding.

Just also fixed the case where we have percentage values as padding.
emilsjolander commented 2017-11-24 06:20:32 -08:00 (Migrated from github.com)
Copy Link

Thanks! This feels super risky from a breakage point of view though. I'll import it now but it may take a while to land

Thanks! This feels super risky from a breakage point of view though. I'll import it now but it may take a while to land
facebook-github-bot (Migrated from github.com) reviewed 2017-11-24 06:20:46 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D6408019).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#649
No description provided.
Delete Branch "percentage_nested"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?