DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix getIframe test helper #66

Merged
kassens merged 1 commits from test-helper into master 2015-03-31 20:42:40 -07:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
kassens commented 2015-03-31 20:33:00 -07:00 (Migrated from github.com)
Copy Link

Chrome seems to always be ready on the first iteration, so this doesn't affect
Chrome, but on Firefox, the iframe is undefined in the recursive call.

This makes most of the test in RunLayoutTests.html pass in Firefox. The only
failing test is the one checking font sizes.

Chrome seems to always be ready on the first iteration, so this doesn't affect Chrome, but on Firefox, the `iframe` is undefined in the recursive call. This makes most of the test in `RunLayoutTests.html` pass in Firefox. The only failing test is the one checking font sizes.
vjeux commented 2015-03-31 20:42:43 -07:00 (Migrated from github.com)
Copy Link

Sweet thanks!

Sweet thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#66
No description provided.
Delete Branch "test-helper"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?