DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix justify content with min/max constraint parent #665

Closed
woehrl01 wants to merge 1 commits from justifyContentMin into master
pull from: justifyContentMin
merge into: DaddyFrosty:master
Conversation 4 Commits 1 Files Changed 6 +700 -4
woehrl01 commented 2017-11-06 13:28:02 -08:00 (Migrated from github.com)
Copy Link

The min/max inner width shouldn't take the margins into account.
Adds a test for both cases.

Fixes #664

The min/max inner width shouldn't take the margins into account. Adds a test for both cases. Fixes #664
lmxxf (Migrated from github.com) reviewed 2017-11-06 18:06:03 -08:00
yoga/Yoga.c
lmxxf (Migrated from github.com) commented 2017-11-06 18:06:03 -08:00
Copy Link

It seems min/maxInnerHeight should be treated same as min/maxInnerWidth ?

It seems min/maxInnerHeight should be treated same as min/maxInnerWidth ?
woehrl01 (Migrated from github.com) reviewed 2017-11-06 21:54:32 -08:00
yoga/Yoga.c
woehrl01 (Migrated from github.com) commented 2017-11-06 21:54:32 -08:00
Copy Link

you're right, thansk. pushed an update.

you're right, thansk. pushed an update.
emilsjolander commented 2017-11-24 06:08:04 -08:00 (Migrated from github.com)
Copy Link

Thanks, and sorry for the delay in reviewing!

Thanks, and sorry for the delay in reviewing!
facebook-github-bot (Migrated from github.com) reviewed 2017-11-24 06:08:21 -08:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@emilsjolander is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.intern.facebook.com/D6407982).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#665
No description provided.
Delete Branch "justifyContentMin"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?