DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Cleanup and extra tests for min/max support #67

Merged
freakboy3742 merged 2 commits from minmax into master 2015-04-01 03:53:58 -07:00
Conversation 0 Commits 2 Files Changed 4 +263 -17
freakboy3742 commented 2015-03-31 23:49:40 -07:00 (Migrated from github.com)
Copy Link

These commits make the change to attribute access picked up during the review of #65, and adds 2 extra tests for a potential division-by-zero situation. As it happens, the code survives that division-by-zero as is, but it can't hurt to test for the situation anyway.

These commits make the change to attribute access picked up during the review of #65, and adds 2 extra tests for a potential division-by-zero situation. As it happens, the code survives that division-by-zero as is, but it can't hurt to test for the situation anyway.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#67
No description provided.
Delete Branch "minmax"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?