DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Remove unused code pointed by Xcode #70

Merged
tadeuzagallo merged 1 commits from remove-dead-code into master 2015-05-05 08:10:04 -07:00
Conversation 2 Commits 1 Files Changed 3 +21 -60
tadeuzagallo commented 2015-04-24 06:19:51 -07:00 (Migrated from github.com)
Copy Link

Xcode analyze tool pointed out this dead code on react-native, I double checked and everything is still alright after removing it... Was it supposed to be used or can it really just be removed?

Xcode analyze tool pointed out this dead code on react-native, I double checked and everything is still alright after removing it... Was it supposed to be used or can it really just be removed?
vjeux commented 2015-04-24 08:27:10 -07:00 (Migrated from github.com)
Copy Link

If the tests are still passing this is good to me! Can you run make to also remove the obj-c and java parts? Thx

If the tests are still passing this is good to me! Can you run make to also remove the obj-c and java parts? Thx
tadeuzagallo commented 2015-04-24 08:49:29 -07:00 (Migrated from github.com)
Copy Link

I've updated the C and Java files. the npm and make tests are ok. If I run the js tests through html files I get 19 failures, but I checked and it's pre-existent. I'll try to fix then on a next PR.

I've updated the C and Java files. the `npm` and `make` tests are ok. If I run the `js` tests through `html` files I get 19 failures, but I checked and it's pre-existent. I'll try to fix then on a next PR.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#70
No description provided.
Delete Branch "remove-dead-code"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?