DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Transpile to update the changes of consts omitted in #69 #72

Merged
Kroisse merged 1 commits from fix-consts into master 2015-04-27 09:23:43 -07:00
Conversation 1 Commits 1 Files Changed 4 +58 -58
Kroisse commented 2015-04-25 22:19:19 -07:00 (Migrated from github.com)
Copy Link

#69 includes the changes of preDefinedTextSizes but the corresponding transpiled results are omitted. So currently they have different text size constants that the JavaScript test case and C and Java's one.

#69 includes [the changes of `preDefinedTextSizes`](https://github.com/facebook/css-layout/blob/1cbb5eef26478bc79ae4f823cd15e537f90e26c0/src/Layout-test-utils.js#L362-L368) but the corresponding transpiled results are omitted. So currently they have different text size constants that the JavaScript test case and C and Java's one.
vjeux commented 2015-04-27 09:23:41 -07:00 (Migrated from github.com)
Copy Link

Thanks!

Thanks!
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#72
No description provided.
Delete Branch "fix-consts"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?