DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

C#: Change NaN with large number #817

Closed
rigdern wants to merge 1 commits from rigdern/cs-nan into master
pull from: rigdern/cs-nan
merge into: DaddyFrosty:master
Conversation 1 Commits 1 Files Changed 1 +19 -2
rigdern commented 2018-09-30 21:24:29 -07:00 (Migrated from github.com)
Copy Link

This PR is the C# version of 3a82d2b1a8

The above change moved Yoga away from NaN to facilitate usage of the -ffast-math compiler flag. However, that commit forgot to update the C# implementation.

This PR is the C# version of https://github.com/facebook/yoga/commit/3a82d2b1a8f5b65a2c3bd1407552d3ed2226238e?w=1 The above change moved Yoga away from NaN to facilitate usage of the `-ffast-math` compiler flag. However, that commit forgot to update the C# implementation.
facebook-github-bot (Migrated from github.com) reviewed 2018-10-09 16:50:21 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

shergin is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D10282642).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#817
No description provided.
Delete Branch "rigdern/cs-nan"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?