Fix C# unit tests #818

2018-09-30T21:30:37-07:00

rigdern commented

2018-09-30 21:30:37 -07:00

(Migrated from github.com)

This consists of several fixes:

Some of the C++ functions called by the tests were missing WIN_EXPORT
It looks like Yoga was changed to round up after TestMeasureFuncWithFloat was written. Here's the function call that results in the rounding: 357ca78f9f/yoga/Yoga.cpp (L4019-L4026)
The format of the result of the Print method was changed after TestPrint was written.

This consists of several fixes: - Some of the C++ functions called by the tests were missing `WIN_EXPORT` - It looks like Yoga was changed to round up after `TestMeasureFuncWithFloat` was written. Here's the function call that results in the rounding: https://github.com/facebook/yoga/blob/357ca78f9f7bd86298ef00a1426cac5ca2041d3b/yoga/Yoga.cpp#L4019-L4026 - The format of the result of the `Print` method was changed after `TestPrint` was written.

👍 1

rigdern commented

2018-09-30 21:37:24 -07:00

(Migrated from github.com)

Questions

Should we use WIN_EXPORT on every public C function? My PR adds it to some that broke the tests but maybe we should just add it to all of them.
Are we supposed to use buck to run tests on Windows? It didn't work for me because it seemed to pass clang flags to Microsoft's C++ compiler.
There are some C#-specific tests. Which solution should I be opening for that?
- Facebook.Yoga.Desktop.sln
- Facebook.Yoga.sln
- Facebook.Yoga.Universal.sln

/cc @mattpodwysocki @rozele @matthargett

Questions - Should we use `WIN_EXPORT` on every public C function? My PR adds it to some that broke the tests but maybe we should just add it to all of them. - Are we supposed to use buck to run tests on Windows? It didn't work for me because it seemed to pass clang flags to Microsoft's C++ compiler. - There are some C#-specific tests. Which solution should I be opening for that? - `Facebook.Yoga.Desktop.sln` - `Facebook.Yoga.sln` - `Facebook.Yoga.Universal.sln` /cc @mattpodwysocki @rozele @matthargett

shergin (Migrated from github.com) reviewed 2018-10-09 16:45:46 -07:00

csharp/Windows/Facebook.Yoga.Universal.Tests/YogaNodeTest.cs

shergin (Migrated from github.com) commented

2018-10-09 16:45:46 -07:00

Can we revert this line?

facebook-github-bot (Migrated from github.com) reviewed 2018-10-09 17:02:40 -07:00

facebook-github-bot (Migrated from github.com) left a comment

shergin is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

shergin is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D10282902).

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#818