DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Implement (padding|border|margin)-(start|end) support #86

Merged
lucasr merged 1 commits from start-end into master 2015-05-14 10:10:32 -07:00
Conversation 3 Commits 1 Files Changed 11 +1373 -133
lucasr commented 2015-05-12 05:13:09 -07:00 (Migrated from github.com)
Copy Link

These changes exposed a bug in my previous diff which is fixed now and covered by the new tests i.e. the trailing position has to be set on both main and cross axis.

These changes exposed a bug in my previous diff which is fixed now and covered by the new tests i.e. the trailing position has to be set on both main and cross axis.
vjeux commented 2015-05-12 07:21:36 -07:00 (Migrated from github.com)
Copy Link

Are you going to implement position: absolute; start/end as well? It's not in the spec but without it you can't really implement proper rtl support everywhere

Are you going to implement position: absolute; start/end as well? It's not in the spec but without it you can't really implement proper rtl support everywhere
lucasr commented 2015-05-12 08:54:30 -07:00 (Migrated from github.com)
Copy Link

@vjeux I can do it, just want to make sure we agree on this direction before going ahead.

@vjeux I can do it, just want to make sure we agree on this direction before going ahead.
vjeux commented 2015-05-13 18:11:19 -07:00 (Migrated from github.com)
Copy Link

Can you rebase, it doesn't merge cleanly anymore, sorry :(

Can you rebase, it doesn't merge cleanly anymore, sorry :(
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#86
No description provided.
Delete Branch "start-end"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?