YogaKitSample is neglected and buggy #869

New Issue

2019-03-05T14:40:31-08:00

mulle-kybernetik-tv commented

2019-03-05 14:40:31 -08:00

(Migrated from github.com)

Report

It seems the YogaKitSample project is very neglected. It doesn't build and it produces faulty layouts.

Issues and Steps to Reproduce

Edit Podfile to actually use the local Yoga and not some ancient version (1.9.0 that would be), which won't work, because of a missing function:

use_frameworks!

target 'YogaKitSample' do
  pod 'Yoga', :path => '../../Yoga.podspec'
  pod 'YogaKit', :path => '../../YogaKit.podspec'
  pod 'IGListKit', '~> 2.1.0'
end

Run pod install to get a new xcworkspace file.
Run example in iPhone8 Plus 11.4 Simulator. Click on "Basic Layout".

Expected Behavior

Expected to see something reasonable.

Actual Behavior

But instead see this:

# Report It seems the YogaKitSample project is very neglected. It doesn't build and it produces faulty layouts. # Issues and Steps to Reproduce Edit `Podfile` to actually use the local `Yoga` and not some ancient version (1.9.0 that would be), which won't work, because of a missing function: ``` use_frameworks! target 'YogaKitSample' do pod 'Yoga', :path => '../../Yoga.podspec' pod 'YogaKit', :path => '../../YogaKit.podspec' pod 'IGListKit', '~> 2.1.0' end ``` Run `pod install` to get a new xcworkspace file. Run example in iPhone8 Plus 11.4 Simulator. Click on "Basic Layout". # Expected Behavior Expected to see something reasonable. # Actual Behavior But instead see this: <img width="526" alt="grafik" src="https://user-images.githubusercontent.com/38703833/53842170-0784bb80-3f9f-11e9-9e2f-25f2fb966186.png">

cntrump commented

2020-08-13 00:19:17 -07:00

(Migrated from github.com)

Fixed in my PR: https://github.com/facebook/yoga/pull/1026

philipbel commented

2021-03-21 09:52:32 -07:00

(Migrated from github.com)

@cntrump PR #1026 has not been merged. The sample is still buggy. This can be quite off-putting to people considering YogaKit.

NickGerleman commented

2023-06-13 08:06:54 -07:00

(Migrated from github.com)

We are deprecating YogaKit as part of the Yoga 2.0 release. We are still going to release a new revision based on the current state of the repo, but won't be accepting new contributions, since we are going to be removing it from the repo after.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#869