DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix cmake build / update CMakeLists.txt to use C++11 #887

Closed
shawwn wants to merge 1 commits from 2019-04-12/fix-cmake into master
pull from: 2019-04-12/fix-cmake
merge into: DaddyFrosty:master
Conversation 4 Commits 1 Files Changed 1 +1
shawwn commented 2019-04-12 15:12:58 -07:00 (Migrated from github.com)
Copy Link

On MacOS, the following steps result in build errors:

mkdir build
cd build
cmake ..
make

The problem is that yogacore uses C++11 features (constexpr) but C++11 isn't specified in CMakeLists.txt.

This PR solves the poblem by adding the following code to the bottom of CMakeLists.txt:

set_target_properties(yogacore PROPERTIES CXX_STANDARD 11)

This solution was derived from https://stackoverflow.com/questions/45688522/how-to-enable-c17-in-cmake

On MacOS, the following steps result in build errors: ``` mkdir build cd build cmake .. make ``` The problem is that yogacore uses C++11 features (`constexpr`) but C++11 isn't specified in CMakeLists.txt. This PR solves the poblem by adding the following code to the bottom of CMakeLists.txt: ``` set_target_properties(yogacore PROPERTIES CXX_STANDARD 11) ``` This solution was derived from https://stackoverflow.com/questions/45688522/how-to-enable-c17-in-cmake
shawwn commented 2019-04-12 22:24:16 -07:00 (Migrated from github.com)
Copy Link

I notice yoga's javascript binding requires C++14. Would it make sense for me to change this PR to C++14 instead of C++11?

I went with the minimum C++ version that seemed to work. But if C++14 would be more future-proof, we should go with that instead.

I notice yoga's javascript binding requires C++14. Would it make sense for me to change this PR to C++14 instead of C++11? I went with the minimum C++ version that seemed to work. But if C++14 would be more future-proof, we should go with that instead.
davidaurelio commented 2019-05-14 04:36:18 -07:00 (Migrated from github.com)
Copy Link

C++11 is fine for now, thanks for the fixes!

C++11 is fine for now, thanks for the fixes!
facebook-github-bot (Migrated from github.com) reviewed 2019-05-14 04:36:29 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D15334282).
facebook-github-bot commented 2019-05-14 07:23:26 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio merged this pull request in facebook/yoga@afc1108659.

@davidaurelio merged this pull request in facebook/yoga@afc1108659074fdfa1e51545e65ed8d444096bd4.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#887
No description provided.
Delete Branch "2019-04-12/fix-cmake"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?