DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Build Yoga.dll with Visual Studio 2017 #888

New Issue
Closed
opened 2019-04-13 10:28:18 -07:00 by zedalaye · 2 comments
zedalaye commented 2019-04-13 10:28:18 -07:00 (Migrated from github.com)
Copy Link

Report

Issues and Steps to Reproduce

Unable to build Yoga.dll using buck (to be fair I think I don't know how to use buck to build Yoga)

So... I decided to open the Facebook.Yoga.Desktop.sln solution. I then selected the "Release" target and "x86" platform before "Regenerate" on the Native/yoga project.

Linking failed due missing files (YGFloatOptional.cpp), I removed that file reference from "Source Files". Then compilation succeeded but build failed due to missing symbols (YGValueZero, YGValueUndefined and YGValueAuto and the log methods)

I had to add YGValue.h and YGValue.cpp and log.h and log.cpp to the project then regenerate and... yipee ! compilation and linking succeeded.

Now I'm asking whether to port Yoga code in Delphi (Object Pascal) or to wrap that Yoga DLL...

# Report - [X] I have searched [existing issues](https://github.com/facebook/yoga/issues) and this is not a duplicate # Issues and Steps to Reproduce Unable to build Yoga.dll using buck (to be fair I think I don't know how to use buck to build Yoga) So... I decided to open the Facebook.Yoga.Desktop.sln solution. I then selected the "Release" target and "x86" platform before "Regenerate" on the Native/yoga project. Linking failed due missing files (YGFloatOptional.cpp), I removed that file reference from "Source Files". Then compilation succeeded but build failed due to missing symbols (YGValueZero, YGValueUndefined and YGValueAuto and the log methods) I had to add YGValue.h and YGValue.cpp and log.h and log.cpp to the project then regenerate and... yipee ! compilation and linking succeeded. Now I'm asking whether to port Yoga code in Delphi (Object Pascal) or to wrap that Yoga DLL...
wqweto commented 2019-04-14 09:30:09 -07:00 (Migrated from github.com)
Copy Link

It's been like this since 1.8 (or when the rewrite in C++ happened).

Doubt the tests on Windows are running at all so use the compiled DLL on your own risk.

It's been like this since 1.8 (or when the rewrite in C++ happened). Doubt the tests on Windows are running at all so use the compiled DLL on your own risk.
NickGerleman commented 2023-06-05 19:05:33 -07:00 (Migrated from github.com)
Copy Link

The C# bindings have not had a dedicated maintainer. We are removing them from the repo as part of cleanup for the next OSS release of Yoga.

The C# bindings have not had a dedicated maintainer. We are removing them from the repo as part of cleanup for the next OSS release of Yoga.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
C#
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#888
No description provided.
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?