DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Compile Issues with Recent GCC #895

Closed
HurricaneJames wants to merge 4 commits from fixes into master
pull from: fixes
merge into: DaddyFrosty:master
Conversation 4 Commits 4 Files Changed 5 +38 -27
HurricaneJames commented 2019-05-15 12:27:10 -07:00 (Migrated from github.com)
Copy Link

GCC 8.3.0 (and possibly all gcc 7+) identified several warnings for signed unsigned integer comparison. With -Werror enabled this broke compiling tests. I suspect the warning is related to google/googletest#683. This diff updates those ASSERT_EQ calls that attempt to compare signed and unsigned errors by specifically declaring the literals to be unsigned.

There is also an issue with Buck where it will not link to pthreads. facebook/buck#1443. Adding a prebuilt_cxx_library for pthread fixes that issue and the tests will compile and run.

Finally, there was a warning about a missing return after a switch in InstrumentationTest.cpp. I added a return "" as a default, but it might be better to throw something. Thoughts?

GCC 8.3.0 (and possibly all gcc 7+) identified several warnings for signed unsigned integer comparison. With `-Werror` enabled this broke compiling tests. I suspect the warning is related to google/googletest#683. This diff updates those `ASSERT_EQ` calls that attempt to compare signed and unsigned errors by specifically declaring the literals to be unsigned. There is also an issue with Buck where it will not link to pthreads. facebook/buck#1443. Adding a `prebuilt_cxx_library` for pthread fixes that issue and the tests will compile and run. Finally, there was a warning about a missing return after a switch in `InstrumentationTest.cpp`. I added a `return ""` as a default, but it might be better to throw something. Thoughts?
facebook-github-bot (Migrated from github.com) reviewed 2019-05-17 07:37:42 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D15393082).
facebook-github-bot (Migrated from github.com) reviewed 2019-05-30 14:15:33 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@HurricaneJames has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@HurricaneJames has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://phabricator.internmc.facebook.com/D15393082).
facebook-github-bot (Migrated from github.com) reviewed 2019-06-11 09:39:35 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@HurricaneJames has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@HurricaneJames has imported this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://our.intern.facebook.com/intern/diff/15393082/).
facebook-github-bot commented 2019-07-04 20:13:43 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio merged this pull request in facebook/yoga@1c8e8d3aec.

@davidaurelio merged this pull request in facebook/yoga@1c8e8d3aecc521642948e9f0676f57f56509d358.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#895
No description provided.
Delete Branch "fixes"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?