DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Fix compilation with CMake #909

Closed
Timmmm wants to merge 1 commits from patch-2 into master
pull from: patch-2
merge into: DaddyFrosty:master
Conversation 6 Commits 1 Files Changed 1 +1
Timmmm commented 2019-06-26 08:39:57 -07:00 (Migrated from github.com)
Copy Link

This adds the root of the source tree to the include path, which allow #include <yoga/YGEnums.h> to work.

Fixes #908

This adds the root of the source tree to the include path, which allow `#include <yoga/YGEnums.h>` to work. Fixes #908
facebook-github-bot commented 2019-06-26 09:05:44 -07:00 (Migrated from github.com)
Copy Link

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need the corporate CLA signed. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23909). Thanks!
facebook-github-bot commented 2019-06-27 03:32:15 -07:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
davidaurelio commented 2019-08-07 16:44:19 -07:00 (Migrated from github.com)
Copy Link

Thank you for the fix!

Thank you for the fix!
facebook-github-bot (Migrated from github.com) reviewed 2019-08-07 16:44:30 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://our.intern.facebook.com/intern/diff/16701716/).
facebook-github-bot commented 2019-08-08 01:01:38 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio merged this pull request in facebook/yoga@a218880216.

@davidaurelio merged this pull request in facebook/yoga@a21888021624defe0d18eca2cf6db56de724fad0.
facebook-github-bot commented 2019-08-08 01:01:54 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio merged this pull request in facebook/yoga@a218880216.

@davidaurelio merged this pull request in facebook/yoga@a21888021624defe0d18eca2cf6db56de724fad0.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#909
No description provided.
Delete Branch "patch-2"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?