DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Properly test for the lack of a node measure func in YogaKit #915

Closed
nferruzzi wants to merge 1 commits from fixYogaKit into master
pull from: fixYogaKit
merge into: DaddyFrosty:master
Conversation 3 Commits 1 Files Changed 1 +1 -1
nferruzzi commented 2019-07-13 11:11:42 -07:00 (Migrated from github.com)
Copy Link

The test was broken and caused a few crashes on my project.

The test was broken and caused a few crashes on my project.
davidaurelio commented 2019-08-07 16:41:41 -07:00 (Migrated from github.com)
Copy Link

Thanks for fixing!

Thanks for fixing!
facebook-github-bot (Migrated from github.com) reviewed 2019-08-07 16:41:50 -07:00
facebook-github-bot (Migrated from github.com) left a comment
Copy Link

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@davidaurelio is landing this pull request. If you are a Facebook employee, you can view this diff [on Phabricator](https://our.intern.facebook.com/intern/diff/16701613/).
facebook-github-bot commented 2019-08-08 01:01:38 -07:00 (Migrated from github.com)
Copy Link

@davidaurelio merged this pull request in facebook/yoga@0f2350308e.

@davidaurelio merged this pull request in facebook/yoga@0f2350308ed977f856bb8593a9bbeba8401c544a.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#915
No description provided.
Delete Branch "fixYogaKit"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?