DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

fix gradle compliation #925

Closed
amir-shalem wants to merge 1 commits from export-D17274226 into master
pull from: export-D17274226
merge into: DaddyFrosty:master
Conversation 1 Commits 1 Files Changed 10 +91 -8
amir-shalem commented 2019-09-10 06:47:49 -07:00 (Migrated from github.com)
Copy Link

Summary:
Gradle is failing to compile yoga for two reasons:

  1. Ever since YogaNodeJNIPhantomRefs was introduced which uses DestructorThread.Destructor from fbjni which was the first direct Java dependency from yoga java to fbjni java code.

  2. Adding a missing gradle endpoint for testutil since it is now required for yoga unit-tests

Differential Revision: D17274226

Summary: Gradle is failing to compile yoga for two reasons: 1. Ever since `YogaNodeJNIPhantomRefs` was introduced which uses `DestructorThread.Destructor` from fbjni which was the first direct Java dependency from yoga java to fbjni java code. 2. Adding a missing gradle endpoint for `testutil` since it is now required for yoga unit-tests Differential Revision: D17274226
facebook-github-bot commented 2019-09-10 09:50:14 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@31de91bbac.

This pull request has been merged in facebook/yoga@31de91bbac22df7a7e03271e98f730e50c0d36d1.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#925
No description provided.
Delete Branch "export-D17274226"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?