Add print yoga node AllEdge value when debug mode #948

2019-11-10T07:49:57-08:00

acton393 commented

2019-11-10 07:49:57 -08:00

(Migrated from github.com)

add print yoga node AllEdge value when debug mode, the old logic just print four edgeValue including top left bottom and right

but when we set the same value to these edge, we use YGAllEdge, this will be more convenient debug code

so I open this pull request to add it

add print yoga node AllEdge value when debug mode, the old logic just print four edgeValue including top left bottom and right but when we set the same value to these edge, we use YGAllEdge, this will be more convenient debug code so I open this pull request to add it

acton393 commented

2019-11-10 07:55:31 -08:00

(Migrated from github.com)

![image](https://user-images.githubusercontent.com/11631084/68546801-84f9a900-0415-11ea-89b9-4af764fdd1d9.png)

NickGerleman (Migrated from github.com) reviewed 2022-12-29 10:20:20 -08:00

yoga/YGNodePrint.cpp

						
				@@ -90,7 +90,8 @@ static void appendEdges(

				    const string& key,

NickGerleman (Migrated from github.com) commented

2022-12-29 10:20:20 -08:00

This could also be the combination of YGEdgeVertical or YGEdgeHorizontal. I think the robust way to do this would be to call one of the node edge resolution functions (computeEdgeValueForColumn() or computeEdgeValueForRow())

This could also be the combination of YGEdgeVertical or YGEdgeHorizontal. I think the robust way to do this would be to call one of the node edge resolution functions (`computeEdgeValueForColumn()` or `computeEdgeValueForRow()`)

NickGerleman commented

2023-02-22 20:15:59 -08:00

(Migrated from github.com)

Wow I didn't expect you to come back, 3 years later 😅. Thanks for the PR!

NickGerleman (Migrated from github.com) approved these changes 2023-02-22 20:16:05 -08:00

facebook-github-bot commented

2023-02-22 20:16:36 -08:00

(Migrated from github.com)

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D43525328).

cortinico (Migrated from github.com) approved these changes 2023-02-23 03:09:38 -08:00

acton393 commented

2023-02-23 09:22:24 -08:00

(Migrated from github.com)

Wow I didn't expect you to come back, 3 years later 😅. Thanks for the PR!

😂😂 I become active recently, and receiving the code review message from my inbox

> Wow I didn't expect you to come back, 3 years later 😅. Thanks for the PR! 😂😂 I become active recently, and receiving the code review message from my inbox

facebook-github-bot commented

2023-02-24 13:45:55 -08:00

(Migrated from github.com)

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D43525328).

facebook-github-bot commented

2023-02-27 08:23:16 -08:00

(Migrated from github.com)

@NickGerleman merged this pull request in facebook/yoga@3f9f0f3ceb.

@NickGerleman merged this pull request in facebook/yoga@3f9f0f3ceb2f94930641556fc97c9319fc9c9cbd.

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#948

				`@@ -90,7 +90,8 @@ static void appendEdges(`
				`const string& key,`