DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Export YGInteropSetLogger method #960

Closed
KimDaeWook wants to merge 3 commits from master into main
pull from: master
merge into: DaddyFrosty:main
Conversation 9 Commits 3 Files Changed 3 +7 -1
KimDaeWook commented 2020-01-10 23:09:42 -08:00 (Migrated from github.com)
Copy Link

When building and using C # libraries,
EntryPointNotFoundException thrown from YGInteropSetLogger.

so, I added YOGA_EXPORT on YGInteropSetLogger.

When building and using C # libraries, EntryPointNotFoundException thrown from YGInteropSetLogger. so, I added YOGA_EXPORT on YGInteropSetLogger.
facebook-github-bot commented 2020-01-10 23:09:53 -08:00 (Migrated from github.com)
Copy Link

Hi KimDaeWook! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

Hi KimDaeWook! Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.In order for us to review and merge your code, please sign at <https://code.facebook.com/cla>. **If you are contributing on behalf of someone else (eg your employer)**, the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [cla@fb.com](mailto:cla@fb.com?subject=CLA%20for%20facebook%2Fyoga%20%23960). Thanks!
facebook-github-bot commented 2020-01-10 23:36:13 -08:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
facebook-github-bot commented 2020-01-11 00:17:04 -08:00 (Migrated from github.com)
Copy Link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!
KimDaeWook commented 2020-01-11 00:48:01 -08:00 (Migrated from github.com)
Copy Link

And YGConfigGetUseLegacyStretchBehaviour is not defined, so i add it additionally.

And YGConfigGetUseLegacyStretchBehaviour is not defined, so i add it additionally.
SidharthGuglani-zz (Migrated from github.com) reviewed 2020-02-28 08:08:03 -08:00
yoga/Yoga.cpp
@@ -4363,6 +4363,11 @@ YOGA_EXPORT void YGConfigSetUseWebDefaults(
config->useWebDefaults = enabled;
}
YOGA_EXPORT bool YGConfigGetUseLegacyStretchBehaviour(
SidharthGuglani-zz (Migrated from github.com) commented 2020-02-28 08:08:03 -08:00
Copy Link

Do you really need this ? This flag might be removed in future.

Do you really need this ? This flag might be removed in future.
SidharthGuglani-zz commented 2020-02-28 08:10:12 -08:00 (Migrated from github.com)
Copy Link

Thanks for creating this PR.
Will merge the PR for adding YOGA_EXPORT to YGInteropSetLogger after you remove other changes

Thanks for creating this PR. Will merge the PR for adding YOGA_EXPORT to YGInteropSetLogger after you remove other changes
NickGerleman commented 2022-10-03 09:57:03 -07:00 (Migrated from github.com)
Copy Link

It looks like the C# bindings already assume YGConfigGetUseLegacyStretchBehaviour. From recent discussions on RN compatibility, I don't think we will be able to remove the flag soon, so adding a public accessor seems righteous to me.

Otherwise, fixing the mismatch in export declaration is a good change.

It looks like the C# bindings already assume `YGConfigGetUseLegacyStretchBehaviour`. From recent discussions on RN compatibility, I don't think we will be able to remove the flag soon, so adding a public accessor seems righteous to me. Otherwise, fixing the mismatch in export declaration is a good change.
NickGerleman (Migrated from github.com) approved these changes 2022-10-03 09:57:12 -07:00
facebook-github-bot commented 2022-10-03 09:57:46 -07:00 (Migrated from github.com)
Copy Link

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@NickGerleman has imported this pull request. If you are a Meta employee, you can view this diff [on Phabricator](https://www.internalfb.com/diff/D40027238).

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
NickGerleman
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#960
No description provided.
Delete Branch "master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?