DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Enhance build process #994

Closed
SidharthGuglani-zz wants to merge 1 commits from export-D20808623 into master
pull from: export-D20808623
merge into: DaddyFrosty:master
Conversation 2 Commits 1 Files Changed 4 +30 -3
SidharthGuglani-zz commented 2020-04-06 02:16:45 -07:00 (Migrated from github.com)
Copy Link

Summary:
After building yoga aar, we found several issues:

  1. More dynamic so files. This is bad as lower-end Android devices cannot load that many sos.
  2. Size increase.
  3. (Minor) The libs are stored in asset folder rather than "libs/".

We apply the following optimizations:

  1. Remove dependency on memalign16 (this is brought in by a pure header dependency jni-hack);
  2. Enable native relinker to remove unused symbols in the so files.
  3. Link yogacore statically to reduce size churn.

Differential Revision: D20808623

Summary: After building yoga aar, we found several issues: 1. More dynamic so files. This is bad as lower-end Android devices cannot load that many sos. 2. Size increase. 3. (Minor) The libs are stored in asset folder rather than "libs/". We apply the following optimizations: 1. Remove dependency on memalign16 (this is brought in by a pure header dependency jni-hack); 2. Enable native relinker to remove unused symbols in the so files. 3. Link yogacore statically to reduce size churn. Differential Revision: D20808623
facebook-github-bot commented 2020-04-06 02:17:04 -07:00 (Migrated from github.com)
Copy Link

This pull request was exported from Phabricator. Differential Revision: D20808623

This pull request was **exported** from Phabricator. Differential Revision: [D20808623](https://phabricator.intern.facebook.com/D20808623)
facebook-github-bot commented 2020-04-06 13:38:12 -07:00 (Migrated from github.com)
Copy Link

This pull request has been merged in facebook/yoga@5eba2d42bd.

This pull request has been merged in facebook/yoga@5eba2d42bd6fde1092439cbc3388ae0a3cc561d9.

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
Algorithm
Build and Infrastructure
C#
C++ Enhancement
CLA Signed
Discussion
Documentation
Feature Request
Java
JavaScript
Merged
Question
Reverted
Shared with Meta
Applied via automation to indicate that an Issue or Pull Request has been shared with the team.
YogaKit
YogaLayout ViewGroup
bug
dependencies
Pull requests that update a dependency file
duplicate
enhancement
fb-exported
fh:direct-merge-enabled
invalid
ruby
Pull requests that update Ruby code
wontfix
No Label
CLA Signed
Merged
fb-exported
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
DaddyFrosty
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: DaddyFrosty/yoga#994
No description provided.
Delete Branch "export-D20808623"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?