WIP: Fix missing invalidation if owner has undefined dimensions #1017
@@ -49,3 +49,33 @@ TEST(YogaTest, recalculate_resolvedDimonsion_onchange) {
|
|||||||
|
|
||||||
YGNodeFreeRecursive(root);
|
YGNodeFreeRecursive(root);
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|
||||||
|
YGSize _measureRecalc(YGNodeRef node, float width, YGMeasureMode widthMode, float height, YGMeasureMode heightMode) {
|
||||||
|
return YGSize { 0, 0};
|
||||||
|
}
|
||||||
|
|
||||||
|
TEST(YogaTest, recalculate_on_layout_values_change) {
|
||||||
|
const YGConfigRef config = YGConfigNew();
|
||||||
|
YGConfigSetExperimentalFeatureEnabled(config, YGExperimentalFeatureWebFlexBasis, true);
|
||||||
|
YGConfigSetPointScaleFactor(config, 3.f);
|
||||||
|
const YGNodeRef root = YGNodeNewWithConfig(config);
|
||||||
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
||||||
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
||||||
|
YGNodeStyleSetAlignContent(root, YGAlignFlexStart);
|
||||||
|
const YGNodeRef child = YGNodeNewWithConfig(config);
|
||||||
|
YGNodeStyleSetMinHeightPercent(child, 40.f);
|
||||||
|
YGNodeStyleSetMaxHeightPercent(child, 60.f);
|
||||||
|
YGNodeStyleSetHeight(child, 10.f);
|
||||||
|
YGNodeStyleSetWidth(child, 50.0f);
|
||||||
|
YGNodeSetMeasureFunc(child, _measureRecalc);
|
||||||
|
YGNodeInsertChild(root, child, 0);
|
||||||
|
|
||||||
|
YGNodeCalculateLayout(root, 50.0f, YGUndefined, YGDirectionLTR);
|
||||||
|
ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(child));
|
||||||
|
|
||||||
|
YGNodeCalculateLayout(root, 50.0f, 30.0f, YGDirectionLTR);
|
||||||
|
ASSERT_FLOAT_EQ(12, YGNodeLayoutGetHeight(child));
|
||||||
|
|
||||||
|
YGNodeFreeRecursive(root);
|
||||||
|
}
|
||||||
|
@@ -39,6 +39,9 @@ public:
|
|||||||
uint32_t generationCount = 0;
|
uint32_t generationCount = 0;
|
||||||
YGDirection lastOwnerDirection = YGDirectionInherit;
|
YGDirection lastOwnerDirection = YGDirectionInherit;
|
||||||
|
|
||||||
|
bool lastOwnerHadUndefinedHeight = false;
|
||||||
|
bool lastOwnerHadUndefinedWidth = false;
|
||||||
|
|
||||||
uint32_t nextCachedMeasurementsIndex = 0;
|
uint32_t nextCachedMeasurementsIndex = 0;
|
||||||
std::array<YGCachedMeasurement, YG_MAX_CACHED_RESULT_COUNT>
|
std::array<YGCachedMeasurement, YG_MAX_CACHED_RESULT_COUNT>
|
||||||
cachedMeasurements = {};
|
cachedMeasurements = {};
|
||||||
|
@@ -3867,9 +3867,14 @@ bool YGLayoutNodeInternal(
|
|||||||
|
|
||||||
depth++;
|
depth++;
|
||||||
|
|
||||||
|
bool ownerHasUndefinedHeight = YGFloatIsUndefined(ownerHeight);
|
||||||
|
bool ownerHasUndefinedWidth = YGFloatIsUndefined(ownerWidth);
|
||||||
|
|
||||||
const bool needToVisitNode =
|
const bool needToVisitNode =
|
||||||
(node->isDirty() && layout->generationCount != generationCount) ||
|
(node->isDirty() && layout->generationCount != generationCount) ||
|
||||||
layout->lastOwnerDirection != ownerDirection;
|
layout->lastOwnerDirection != ownerDirection ||
|
||||||
|
layout->lastOwnerHadUndefinedHeight != ownerHasUndefinedHeight||
|
||||||
|
layout->lastOwnerHadUndefinedWidth != ownerHasUndefinedWidth;
|
||||||
|
|
||||||
if (needToVisitNode) {
|
if (needToVisitNode) {
|
||||||
// Invalidate the cached results.
|
// Invalidate the cached results.
|
||||||
@@ -4051,6 +4056,8 @@ bool YGLayoutNodeInternal(
|
|||||||
}
|
}
|
||||||
|
|
||||||
layout->lastOwnerDirection = ownerDirection;
|
layout->lastOwnerDirection = ownerDirection;
|
||||||
|
layout->lastOwnerHadUndefinedHeight = ownerHasUndefinedHeight;
|
||||||
|
layout->lastOwnerHadUndefinedWidth = ownerHasUndefinedWidth;
|
||||||
|
|
||||||
if (cachedResults == nullptr) {
|
if (cachedResults == nullptr) {
|
||||||
if (layout->nextCachedMeasurementsIndex + 1 >
|
if (layout->nextCachedMeasurementsIndex + 1 >
|
||||||
|
Reference in New Issue
Block a user