DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add support for Swift Package Manager #1032

Closed
salling wants to merge 17 commits from swiftpm into main
pull from: swiftpm
merge into: DaddyFrosty:main
Conversation 11 Commits 17 Files Changed 3 +43
7 changed files with 43 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 8e8a4c901c - Show all commits

21
Package.swift
View File

@@ -19,18 +19,19 @@ let package = Package(
name: "yoga", name: "yoga",
dependencies: [], dependencies: [],
path: "./yoga", path: "./yoga",
publicHeadersPath: "./yoga", // publicHeadersPath: "./yoga",
cxxSettings: [ cxxSettings: [
.headerSearchPath("../"), .headerSearchPath("../"),
.unsafeFlags([ // .unsafeFlags([
"-fno-omit-frame-pointer", // "-fno-omit-frame-pointer",
"-fexceptions", // "-fexceptions",
"-Wall", // "-Wall",
"-Werror", // "-Werror",
"-std=c++1y", // "-std=c++1y",
"-fPIC", // "-fPIC",
]) // ])
] ]
) )
cipolleschi commented 2023-06-15 18:00:46 -07:00 (Migrated from github.com)
Review
Copy Link

this should probably be .cxx17, as this is the version we are typically using internally.

this should probably be `.cxx17`, as this is the version we are typically using internally.
NickGerleman commented 2023-06-16 13:39:44 -07:00 (Migrated from github.com)
Review
Copy Link

Yoga is targeting C++14 for a little bit longer. There was some unhappiness when I tried to bump from C++ 11 directly to 17.

LLVM has had C++ 17 support for almost six years though, so I do plan for us to do a bump later this year. Same rules for same infra, and unlocking more support.

See https://github.com/facebook/yoga/pull/1203 for discussion

Yoga is targeting C++14 for a little bit longer. There was some unhappiness when I tried to bump from C++ 11 directly to 17. LLVM has had C++ 17 support for almost six years though, so I do plan for us to do a bump later this year. Same rules for same infra, and unlocking more support. See https://github.com/facebook/yoga/pull/1203 for discussion
] ],
cxxLanguageStandard: .cxx11
) )

1
yoga/include/YGEnums.h Symbolic link
View File

@@ -0,0 +1 @@
../YGEnums.h

1
yoga/include/YGMacros.h Symbolic link
View File

@@ -0,0 +1 @@
../YGMacros.h

1
yoga/include/YGNode.h Symbolic link
View File

@@ -0,0 +1 @@
../YGNode.h

1
yoga/include/YGStyle.h Symbolic link
View File

@@ -0,0 +1 @@
../YGStyle.h

1
yoga/include/YGValue.h Symbolic link
View File

@@ -0,0 +1 @@
../YGValue.h

1
yoga/include/Yoga.h Symbolic link
View File

@@ -0,0 +1 @@
../Yoga.h