DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Rewrite CompactValue to avoid undefined behavior from the use of a union for type-punning #1154

Closed
htpiv wants to merge 4 commits from htpiv/use-bit-cast into main
pull from: htpiv/use-bit-cast
merge into: DaddyFrosty:main
Conversation 5 Commits 4 Files Changed 1 +55 -37
1 changed files with 55 additions and 37 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 68b780fa37 - Show all commits

4
yoga/CompactValue.h
View File

@@ -11,6 +11,8 @@
#ifdef __cpp_lib_bit_cast
#include <bit>
#else
#include <cstring>
#endif
rozele commented 2022-07-25 10:01:53 -07:00 (Migrated from github.com)
Review
Copy Link

Looks like internal builds are failing because std::memcpy requires #include <cstring>

Looks like internal builds are failing because std::memcpy requires `#include <cstring>`
#include "YGValue.h"
#include "YGMacros.h"
@@ -169,7 +171,7 @@ private:
static float asFloat(uint32_t u) {
#ifdef __cpp_lib_bit_cast
return std::bit_cast<float>(data);
return std::bit_cast<float>(u);
#else
float f;
static_assert(sizeof(f) == sizeof(u), "uint32_t and float must have the same size");