From 4a0c7a0894cfc1850d9cf5002457ed526db889b5 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Sun, 10 Mar 2024 22:00:16 -0700 Subject: [PATCH] Reduce warning level of distributed Yoga builds Summary: Yoga may be built with a high warning level. This is helpful in letting Yoga be used in more places, and finding defects. We currently set these in the internal BUCK build, the CMake reference build, and the Yoga Standalone (not RN) CocoaPods build. Yoga's reference CMake build and spec are consumed today by users of Yoga, instead of just Yoga developers. Here, it makes more sense to avoid anything that could break compiler-to-compiler compatibility. We default these to a less intense (`-Wall -Werror`). I kept `/W4`, for pragmatic reasons, and since it is relatively standard for MSVC. We continue to build with strict flags on Buck build on Clang. Fixes https://github.com/facebook/yoga/issues/1590 Differential Revision: D54735661 --- Yoga.podspec | 2 -- cmake/project-defaults.cmake | 2 -- 2 files changed, 4 deletions(-) diff --git a/Yoga.podspec b/Yoga.podspec index 719829ca..9d9b6180 100644 --- a/Yoga.podspec +++ b/Yoga.podspec @@ -33,8 +33,6 @@ Pod::Spec.new do |spec| '-fexceptions', '-Wall', '-Werror', - '-Wextra', - '-Wconversion', '-std=c++20', '-fPIC' ] diff --git a/cmake/project-defaults.cmake b/cmake/project-defaults.cmake index c262bac8..987529c5 100644 --- a/cmake/project-defaults.cmake +++ b/cmake/project-defaults.cmake @@ -33,9 +33,7 @@ add_compile_options( -fexceptions # Enable warnings and warnings as errors -Wall - -Wextra -Werror - -Wconversion # Disable RTTI $<$:-fno-rtti> # Use -O2 (prioritize speed) -- 2.50.1.windows.1