From f3793303f3c930f598d71013ce121bd17926d99f Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Tue, 21 Jan 2025 11:44:49 -0800 Subject: [PATCH 1/3] Try fixing CI after GHA Ubuntu 24.04 Update New GHA images seem to have dropped the preinstalled libc++ package. Let's manually install it during setup. --- .github/actions/setup-cpp/action.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/actions/setup-cpp/action.yml b/.github/actions/setup-cpp/action.yml index 4f618267..f3aece30 100644 --- a/.github/actions/setup-cpp/action.yml +++ b/.github/actions/setup-cpp/action.yml @@ -16,6 +16,7 @@ runs: if: ${{ inputs.toolchain == 'Clang' }} shell: bash run: | + sudo apt-get install -y libc++-dev libc++abi-dev echo "CC=/usr/bin/clang" >> $GITHUB_ENV echo "CXX=/usr/bin/clang++" >> $GITHUB_ENV echo "CXXFLAGS=-stdlib=libc++" >> $GITHUB_ENV -- 2.50.1.windows.1 From cb6dd1d01ec09e5dea045485d80b755c5ba6a661 Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Tue, 21 Jan 2025 11:48:21 -0800 Subject: [PATCH 2/3] Update clang-format version --- .github/actions/clang-format/action.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/actions/clang-format/action.yml b/.github/actions/clang-format/action.yml index b81af54f..65d6d374 100644 --- a/.github/actions/clang-format/action.yml +++ b/.github/actions/clang-format/action.yml @@ -6,7 +6,7 @@ inputs: version: description: LLVM version to use # Should be kept roughly in sync with arcanist required: false - default: 12 + default: 18 runs: using: "composite" -- 2.50.1.windows.1 From 74face1db4eca6920a38aa8598a1aee81e1d869d Mon Sep 17 00:00:00 2001 From: Nick Gerleman Date: Tue, 21 Jan 2025 11:50:12 -0800 Subject: [PATCH 3/3] huh? --- .github/workflows/validate-cpp.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/validate-cpp.yml b/.github/workflows/validate-cpp.yml index e2c159d1..1d9ba8d1 100644 --- a/.github/workflows/validate-cpp.yml +++ b/.github/workflows/validate-cpp.yml @@ -107,3 +107,5 @@ jobs: - name: clang-format uses: ./.github/actions/clang-format + with: + directory: yoga -- 2.50.1.windows.1