DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Baseline support #317

Closed
woehrl01 wants to merge 33 commits from baseline-support into master
pull from: baseline-support
merge into: DaddyFrosty:master
Conversation 39 Commits 33 Files Changed 20 +4605 -7
20 changed files with 4605 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1d9855b405 - Show all commits

3
yoga/Yoga.c
View File

@@ -1015,6 +1015,9 @@ static inline bool YGNodeIsFlex(const YGNodeRef node) {
}
emilsjolander commented 2017-01-05 11:15:01 -08:00 (Migrated from github.com)
Review
Copy Link

nit: empty line above

nit: empty line above
emilsjolander commented 2017-01-05 12:07:59 -08:00 (Migrated from github.com)
Review
Copy Link

Please add this 👍

Please add this 👍
woehrl01 commented 2017-01-05 12:18:27 -08:00 (Migrated from github.com)
Review
Copy Link

not sure what you mean, should I add a empty line above return false?

not sure what you mean, should I add a empty line above ```return false```?
static bool YGIsBaselineLayout(const YGNodeRef node) {
if (YGFlexDirectionIsColumn(node->style.flexDirection)) {
return false;
}
if (node->style.alignItems == YGAlignBaseline) {
return true;
}