DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Add Carthage & CocoaPods support. #352

Closed
guidomb wants to merge 4 commits from carthage-cocoapods-support into master
pull from: carthage-cocoapods-support
merge into: DaddyFrosty:master
Conversation 57 Commits 4 Files Changed 14 +645 -5
14 changed files with 645 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 95df27d5f4 - Show all commits

9
YogaKit/YogaKit.podspec
View File

@@ -16,17 +16,14 @@ Pod::Spec.new do |spec|
spec.documentation_url = 'https://facebook.github.io/yoga/docs/getting-started/'
spec.source = { :git => 'https://github.com/facebook/yoga.git', :tag => "v#{spec.version}" }
spec.platform = :ios
alloy commented 2017-01-25 21:17:10 -08:00 (Migrated from github.com)
Review
Copy Link

Why is this only targeting iOS, shouldn’t the core library be able to build for all platforms? (So minus the UIView stuff.)

Why is this only targeting iOS, shouldn’t the core library be able to build for all platforms? (So minus the UIView stuff.)
hartbit commented 2017-01-25 22:25:55 -08:00 (Migrated from github.com)
Review
Copy Link

While the core library could technically build on all platforms, I plan to send a PR soon with an NSView extension. I guess we could all platforms then.

While the core library could technically build on all platforms, I plan to send a PR soon with an NSView extension. I guess we could all platforms then.
alloy commented 2017-01-26 06:33:06 -08:00 (Migrated from github.com)
Review
Copy Link

Gotcha.

So then I guess my assumption that this podspec was somehow also tied to React Native’s podspec using this is incorrect. /cc @javache

Gotcha. So then I guess my assumption that this podspec was somehow also tied to React Native’s podspec using this is incorrect. /cc @javache
spec.source_files = 'YogaKit/*.{h,m}', 'lib/*.{h,c}'
spec.source_files = 'YogaKit/*.{h,m}',
spec.public_header_files = [
'YogaKit/YogaKit.h',
'YogaKit/YGLayout.h',
'YogaKit/UIView+Yoga.h',
'lib/YGEnums.h',
'lib/YGMacros.h'
'YogaKit/UIView+Yoga.h'
]
spec.private_header_files = [
'YogaKit/YGLayout+Private.h',
'lib/YGNodeList.h',
'lib/Yoga.h'
]
spec.dependency 'Yoga', path: '../Yoga.podspec'
end

1
YogaKit/lib
View File

@@ -1 +0,0 @@
../yoga