b959c79a2a
Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
70 lines
1.6 KiB
C++
70 lines
1.6 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
#include <yoga/config/Config.h>
|
|
#include <yoga/node/Node.h>
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
|
|
using namespace facebook;
|
|
|
|
struct ConfigCloningTest : public ::testing::Test {
|
|
std::unique_ptr<yoga::Config, std::function<void(yoga::Config*)>> config;
|
|
void SetUp() override;
|
|
void TearDown() override;
|
|
|
|
static yoga::Node clonedNode;
|
|
static YGNodeRef cloneNode(
|
|
YGNodeConstRef /*unused*/,
|
|
YGNodeConstRef /*unused*/,
|
|
size_t /*unused*/) {
|
|
return &clonedNode;
|
|
}
|
|
static YGNodeRef doNotClone(
|
|
YGNodeConstRef /*unused*/,
|
|
YGNodeConstRef /*unused*/,
|
|
size_t /*unused*/) {
|
|
return nullptr;
|
|
}
|
|
};
|
|
|
|
TEST_F(ConfigCloningTest, uses_values_provided_by_cloning_callback) {
|
|
config->setCloneNodeCallback(cloneNode);
|
|
|
|
yoga::Node node{};
|
|
yoga::Node owner{};
|
|
auto clone = config->cloneNode(&node, &owner, 0);
|
|
|
|
ASSERT_EQ(clone, &clonedNode);
|
|
}
|
|
|
|
TEST_F(
|
|
ConfigCloningTest,
|
|
falls_back_to_regular_cloning_if_callback_returns_null) {
|
|
config->setCloneNodeCallback(doNotClone);
|
|
|
|
yoga::Node node{};
|
|
yoga::Node owner{};
|
|
auto clone = config->cloneNode(&node, &owner, 0);
|
|
|
|
ASSERT_NE(clone, nullptr);
|
|
YGNodeFree(clone);
|
|
}
|
|
|
|
void ConfigCloningTest::SetUp() {
|
|
config = {static_cast<yoga::Config*>(YGConfigNew()), YGConfigFree};
|
|
}
|
|
|
|
void ConfigCloningTest::TearDown() {
|
|
config.reset();
|
|
}
|
|
|
|
yoga::Node ConfigCloningTest::clonedNode = {};
|