b959c79a2a
Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
362 lines
9.9 KiB
C++
362 lines
9.9 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/YGEnums.h>
|
|
#include <yoga/Yoga.h>
|
|
#include <yoga/event/event.h>
|
|
|
|
#include <algorithm>
|
|
#include <functional>
|
|
#include <memory>
|
|
#include <vector>
|
|
|
|
#include "util/TestUtil.h"
|
|
|
|
namespace facebook::yoga::test {
|
|
|
|
template <Event::Type E>
|
|
struct TypedEventTestData {};
|
|
|
|
template <>
|
|
struct TypedEventTestData<Event::LayoutPassEnd> {
|
|
LayoutData layoutData;
|
|
};
|
|
|
|
struct EventArgs {
|
|
const YGNodeConstRef node;
|
|
Event::Type type;
|
|
std::unique_ptr<void, std::function<void(void*)>> dataPtr;
|
|
std::unique_ptr<void, std::function<void(void*)>> eventTestDataPtr;
|
|
|
|
template <Event::Type E>
|
|
const Event::TypedData<E>& data() {
|
|
return *static_cast<Event::TypedData<E>*>(dataPtr.get());
|
|
}
|
|
|
|
template <Event::Type E>
|
|
const TypedEventTestData<E>& eventTestData() {
|
|
return *static_cast<TypedEventTestData<E>*>(eventTestDataPtr.get());
|
|
}
|
|
};
|
|
|
|
class EventTest : public ::testing::Test {
|
|
ScopedEventSubscription subscription{&EventTest::listen};
|
|
static void listen(
|
|
YGNodeConstRef /*node*/,
|
|
Event::Type /*type*/,
|
|
Event::Data /*data*/);
|
|
|
|
public:
|
|
static std::vector<EventArgs> events;
|
|
static EventArgs& lastEvent() {
|
|
return events.back();
|
|
}
|
|
void TearDown() override;
|
|
};
|
|
|
|
TEST_F(EventTest, new_node_has_event) {
|
|
auto c = YGConfigGetDefault();
|
|
auto n = YGNodeNew();
|
|
|
|
ASSERT_EQ(lastEvent().node, n);
|
|
ASSERT_EQ(lastEvent().type, Event::NodeAllocation);
|
|
ASSERT_EQ(lastEvent().data<Event::NodeAllocation>().config, c);
|
|
|
|
YGNodeFree(n);
|
|
}
|
|
|
|
TEST_F(EventTest, new_node_with_config_event) {
|
|
auto c = YGConfigNew();
|
|
auto n = YGNodeNewWithConfig(c);
|
|
|
|
ASSERT_EQ(lastEvent().node, n);
|
|
ASSERT_EQ(lastEvent().type, Event::NodeAllocation);
|
|
ASSERT_EQ(lastEvent().data<Event::NodeAllocation>().config, c);
|
|
|
|
YGNodeFree(n);
|
|
YGConfigFree(c);
|
|
}
|
|
|
|
TEST_F(EventTest, clone_node_event) {
|
|
auto c = YGConfigNew();
|
|
auto n = YGNodeNewWithConfig(c);
|
|
auto clone = YGNodeClone(n);
|
|
|
|
ASSERT_EQ(lastEvent().node, clone);
|
|
ASSERT_EQ(lastEvent().type, Event::NodeAllocation);
|
|
ASSERT_EQ(lastEvent().data<Event::NodeAllocation>().config, c);
|
|
|
|
YGNodeFree(n);
|
|
YGNodeFree(clone);
|
|
YGConfigFree(c);
|
|
}
|
|
|
|
TEST_F(EventTest, free_node_event) {
|
|
auto c = YGConfigNew();
|
|
auto n = YGNodeNewWithConfig(c);
|
|
YGNodeFree(n);
|
|
|
|
ASSERT_EQ(lastEvent().node, n);
|
|
ASSERT_EQ(lastEvent().type, Event::NodeDeallocation);
|
|
ASSERT_EQ(lastEvent().data<Event::NodeDeallocation>().config, c);
|
|
|
|
YGConfigFree(c);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events) {
|
|
auto root = YGNodeNew();
|
|
auto child = YGNodeNew();
|
|
YGNodeInsertChild(root, child, 0);
|
|
|
|
YGNodeCalculateLayout(root, 123, 456, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[2].node, root);
|
|
ASSERT_EQ(events[2].type, Event::LayoutPassStart);
|
|
|
|
ASSERT_EQ(events[3].node, child);
|
|
ASSERT_EQ(events[3].type, Event::NodeLayout);
|
|
|
|
ASSERT_EQ(events[4].node, child);
|
|
ASSERT_EQ(events[4].type, Event::NodeLayout);
|
|
|
|
ASSERT_EQ(events[5].node, child);
|
|
ASSERT_EQ(events[5].type, Event::NodeLayout);
|
|
|
|
ASSERT_EQ(events[6].node, root);
|
|
ASSERT_EQ(events[6].type, Event::NodeLayout);
|
|
|
|
ASSERT_EQ(events[7].node, root);
|
|
ASSERT_EQ(events[7].type, Event::LayoutPassEnd);
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events_single_node) {
|
|
auto root = YGNodeNew();
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[1].node, root);
|
|
ASSERT_EQ(events[1].type, Event::LayoutPassStart);
|
|
|
|
ASSERT_EQ(events[2].node, root);
|
|
ASSERT_EQ(events[2].type, Event::NodeLayout);
|
|
|
|
ASSERT_EQ(events[3].node, root);
|
|
ASSERT_EQ(events[3].type, Event::LayoutPassEnd);
|
|
|
|
LayoutData layoutData =
|
|
events[3].eventTestData<Event::LayoutPassEnd>().layoutData;
|
|
|
|
ASSERT_EQ(layoutData.layouts, 1);
|
|
ASSERT_EQ(layoutData.measures, 0);
|
|
ASSERT_EQ(layoutData.maxMeasureCache, 1);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events_counts_multi_node_layout) {
|
|
auto root = YGNodeNew();
|
|
auto childA = YGNodeNew();
|
|
YGNodeInsertChild(root, childA, 0);
|
|
auto childB = YGNodeNew();
|
|
YGNodeInsertChild(root, childB, 1);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[3].node, root);
|
|
ASSERT_EQ(events[3].type, Event::LayoutPassStart);
|
|
|
|
ASSERT_EQ(events[11].node, root);
|
|
ASSERT_EQ(events[11].type, Event::LayoutPassEnd);
|
|
|
|
LayoutData layoutData =
|
|
events[11].eventTestData<Event::LayoutPassEnd>().layoutData;
|
|
|
|
ASSERT_EQ(layoutData.layouts, 3);
|
|
ASSERT_EQ(layoutData.measures, 4);
|
|
ASSERT_EQ(layoutData.maxMeasureCache, 3);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events_counts_cache_hits_single_node_layout) {
|
|
auto root = YGNodeNew();
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[4].node, root);
|
|
ASSERT_EQ(events[4].type, Event::LayoutPassStart);
|
|
|
|
ASSERT_EQ(events[6].node, root);
|
|
ASSERT_EQ(events[6].type, Event::LayoutPassEnd);
|
|
|
|
LayoutData layoutData =
|
|
events[6].eventTestData<Event::LayoutPassEnd>().layoutData;
|
|
|
|
ASSERT_EQ(layoutData.layouts, 0);
|
|
ASSERT_EQ(layoutData.measures, 0);
|
|
ASSERT_EQ(layoutData.cachedLayouts, 1);
|
|
ASSERT_EQ(layoutData.cachedMeasures, 0);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events_counts_cache_hits_multi_node_layout) {
|
|
auto root = YGNodeNew();
|
|
auto childA = YGNodeNew();
|
|
YGNodeInsertChild(root, childA, 0);
|
|
auto childB = YGNodeNew();
|
|
YGNodeInsertChild(root, childB, 1);
|
|
|
|
YGNodeCalculateLayout(root, 987, 654, YGDirectionLTR);
|
|
YGNodeCalculateLayout(root, 123, 456, YGDirectionLTR);
|
|
|
|
YGNodeCalculateLayout(root, 987, 654, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(lastEvent().node, root);
|
|
ASSERT_EQ(lastEvent().type, Event::LayoutPassEnd);
|
|
|
|
LayoutData layoutData =
|
|
lastEvent().eventTestData<Event::LayoutPassEnd>().layoutData;
|
|
|
|
ASSERT_EQ(layoutData.layouts, 3);
|
|
ASSERT_EQ(layoutData.measures, 0);
|
|
ASSERT_EQ(layoutData.maxMeasureCache, 5);
|
|
ASSERT_EQ(layoutData.cachedLayouts, 0);
|
|
ASSERT_EQ(layoutData.cachedMeasures, 4);
|
|
}
|
|
|
|
TEST_F(EventTest, layout_events_has_max_measure_cache) {
|
|
auto root = YGNodeNew();
|
|
auto a = YGNodeNew();
|
|
YGNodeInsertChild(root, a, 0);
|
|
auto b = YGNodeNew();
|
|
YGNodeInsertChild(root, b, 1);
|
|
YGNodeStyleSetFlexBasis(a, 10.0f);
|
|
|
|
for (auto s : {20.0f, 30.0f, 40.0f}) {
|
|
YGNodeCalculateLayout(root, s, s, YGDirectionLTR);
|
|
}
|
|
|
|
ASSERT_EQ(lastEvent().node, root);
|
|
ASSERT_EQ(lastEvent().type, Event::LayoutPassEnd);
|
|
|
|
LayoutData layoutData =
|
|
lastEvent().eventTestData<Event::LayoutPassEnd>().layoutData;
|
|
|
|
ASSERT_EQ(layoutData.layouts, 3);
|
|
ASSERT_EQ(layoutData.measures, 3);
|
|
ASSERT_EQ(layoutData.maxMeasureCache, 7);
|
|
}
|
|
|
|
TEST_F(EventTest, measure_functions_get_wrapped) {
|
|
auto root = YGNodeNew();
|
|
YGNodeSetMeasureFunc(
|
|
root, [](YGNodeConstRef, float, YGMeasureMode, float, YGMeasureMode) {
|
|
return YGSize{};
|
|
});
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[2].node, root);
|
|
ASSERT_EQ(events[2].type, Event::MeasureCallbackStart);
|
|
|
|
ASSERT_EQ(events[events.size() - 1].node, root);
|
|
ASSERT_EQ(events[events.size() - 1].type, Event::LayoutPassEnd);
|
|
}
|
|
|
|
TEST_F(EventTest, baseline_functions_get_wrapped) {
|
|
auto root = YGNodeNew();
|
|
auto child = YGNodeNew();
|
|
YGNodeInsertChild(root, child, 0);
|
|
|
|
YGNodeSetBaselineFunc(
|
|
child, [](YGNodeConstRef, float, float) { return 0.0f; });
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetAlignItems(root, YGAlignBaseline);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(events[5].node, child);
|
|
ASSERT_EQ(events[5].type, Event::NodeBaselineStart);
|
|
|
|
ASSERT_EQ(events[events.size() - 1].node, root);
|
|
ASSERT_EQ(events[events.size() - 1].type, Event::LayoutPassEnd);
|
|
}
|
|
|
|
namespace {
|
|
|
|
template <Event::Type E>
|
|
EventArgs createArgs(YGNodeConstRef node, const Event::Data data) {
|
|
using Data = Event::TypedData<E>;
|
|
auto deleteData = [](void* x) { delete static_cast<Data*>(x); };
|
|
|
|
return {node, E, {new Data{(data.get<E>())}, deleteData}, nullptr};
|
|
}
|
|
|
|
template <Event::Type E>
|
|
EventArgs createArgs(
|
|
YGNodeConstRef node,
|
|
const Event::Data data,
|
|
TypedEventTestData<E> eventTestData) {
|
|
using EventTestData = TypedEventTestData<E>;
|
|
auto deleteEventTestData = [](void* x) {
|
|
delete static_cast<EventTestData*>(x);
|
|
};
|
|
|
|
EventArgs args = createArgs<E>(node, data);
|
|
args.eventTestDataPtr = {
|
|
new EventTestData{eventTestData}, deleteEventTestData};
|
|
return args;
|
|
}
|
|
|
|
} // namespace
|
|
|
|
void EventTest::listen(
|
|
YGNodeConstRef node,
|
|
Event::Type type,
|
|
Event::Data data) {
|
|
switch (type) {
|
|
case Event::NodeAllocation:
|
|
events.push_back(createArgs<Event::NodeAllocation>(node, data));
|
|
break;
|
|
case Event::NodeDeallocation:
|
|
events.push_back(createArgs<Event::NodeDeallocation>(node, data));
|
|
break;
|
|
case Event::NodeLayout:
|
|
events.push_back(createArgs<Event::NodeLayout>(node, data));
|
|
break;
|
|
case Event::LayoutPassStart:
|
|
events.push_back(createArgs<Event::LayoutPassStart>(node, data));
|
|
break;
|
|
case Event::LayoutPassEnd: {
|
|
auto& eventData = data.get<Event::LayoutPassEnd>();
|
|
events.push_back(createArgs<Event::LayoutPassEnd>(
|
|
node, data, {*eventData.layoutData}));
|
|
break;
|
|
}
|
|
|
|
case Event::MeasureCallbackStart:
|
|
events.push_back(createArgs<Event::MeasureCallbackStart>(node, data));
|
|
break;
|
|
case Event::MeasureCallbackEnd:
|
|
events.push_back(createArgs<Event::MeasureCallbackEnd>(node, data));
|
|
break;
|
|
case Event::NodeBaselineStart:
|
|
events.push_back(createArgs<Event::NodeBaselineStart>(node, data));
|
|
break;
|
|
case Event::NodeBaselineEnd:
|
|
events.push_back(createArgs<Event::NodeBaselineEnd>(node, data));
|
|
break;
|
|
}
|
|
}
|
|
|
|
void EventTest::TearDown() {
|
|
events.clear();
|
|
}
|
|
|
|
std::vector<EventArgs> EventTest::events{};
|
|
|
|
} // namespace facebook::yoga::test
|