1813748eaa
Summary: Yoga's JavaScript bindings do not work past Node 10, or on recent versions of Ubuntu even using it. This is due to a reliance on `nbind`, a library which is no longer maintained. `nbind` itself abstracts over `embind` running Emscripten to generate an asm.js build, along with building Node native modules. In the meantime, [yoga-layout-prebuilt](https://www.npmjs.com/package/yoga-layout-prebuilt) has been used by the community instead of the official package. https://github.com/facebook/yoga/pull/1177 was contributed as a conversion of bindings created using `nbind` to instead use `embind` directly. I continued building on this to add more: 1. WebAssembly support (required to be async in browsers) 2. CMake + Ninja Build for the 4 flavors 3. TypeScript typings (partially generated) 4. yarn scripts to build (working on macOS, Ubuntu, Windows) 5. A README with some usage and contribution instructions 6. Updated tests to work with Jest, and updated general infra 7. ESLint and clang-format scripts 8. More GitHub actions (and now testing Windows) 9. Probably more I kinda got carried away here lol The plan is to eventually publish this to NPM, but there is a little bit of work after this before that happens. Pull Request resolved: https://github.com/facebook/yoga/pull/1177 Test Plan: The bindings pass Jest tests (both manual and generated). GitHub actions added for the different yarn scripts. Did some manual checks on using the library as TS. Reviewed By: christophpurrer Differential Revision: D42207782 Pulled By: NickGerleman fbshipit-source-id: 1dc5ce440f1c2b9705a005bbdcc86f952785d94e
28 lines
634 B
YAML
28 lines
634 B
YAML
name: Setup JavaScript envirionment
|
|
|
|
runs:
|
|
using: "composite"
|
|
steps:
|
|
- name: Install Node
|
|
uses: actions/setup-node@v1
|
|
with:
|
|
node-version: 18.x
|
|
|
|
- name: Install emsdk
|
|
uses: ./.github/actions/install-emsdk
|
|
|
|
- name: Install ninja (Linux)
|
|
if: ${{ runner.os == 'Linux' }}
|
|
shell: bash
|
|
run: sudo apt-get install -y ninja-build
|
|
|
|
- name: Install ninja (Windows)
|
|
if: ${{ runner.os == 'Windows' }}
|
|
shell: powershell
|
|
run: choco install ninja
|
|
|
|
- name: yarn install
|
|
shell: bash
|
|
run: yarn install --frozen-lockfile
|
|
working-directory: javascript
|