5bc0197c78
Summary: The issue is on ARM builds for Windows UWP. For the C# P/Invoke API wrapper, any native method that returns the YogaValue struct throws the AccessViolationException. The issue is not with structs in general, as returning the YogaSize / YGSize struct works fine. The issue seems to be limited to structs that have an enum member. I tried a number of things to resolve the issue without changing the underlying native API for Windows. I read the ARM documentation and saw reference to variable enum sizes based on the number of enum members, so I tried to use a number of different UnmanagedType values in a [MarsalAs()] attribute on the enum member of the C# struct declaration. What ultimately worked was to return a pointer to the location of the struct, and use the System.Runtime.InteropServices.PtrToStructure API to read the struct data from that pointer. I added a few new macros that will return the struct address on Windows only, other builds are not affected. Note, I have not tested the impact of this ch Closes https://github.com/facebook/yoga/pull/459 Reviewed By: emilsjolander Differential Revision: D4652278 Pulled By: splhack fbshipit-source-id: bf7ada4da1781e3f813b3ba331974b7bded476d9
110 lines
2.6 KiB
C#
110 lines
2.6 KiB
C#
/**
|
|
* Copyright (c) 2014-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
using System;
|
|
using System.Runtime.InteropServices;
|
|
|
|
namespace Facebook.Yoga
|
|
{
|
|
[StructLayout(LayoutKind.Sequential)]
|
|
public struct YogaValue
|
|
{
|
|
private float value;
|
|
private YogaUnit unit;
|
|
|
|
public YogaUnit Unit
|
|
{
|
|
get
|
|
{
|
|
return unit;
|
|
}
|
|
}
|
|
|
|
public float Value
|
|
{
|
|
get
|
|
{
|
|
return value;
|
|
}
|
|
}
|
|
|
|
public static YogaValue Point(float value)
|
|
{
|
|
return new YogaValue
|
|
{
|
|
value = value,
|
|
unit = YogaConstants.IsUndefined(value) ? YogaUnit.Undefined : YogaUnit.Point
|
|
};
|
|
}
|
|
|
|
public bool Equals(YogaValue other)
|
|
{
|
|
return Unit == other.Unit && (Value.Equals(other.Value) || Unit == YogaUnit.Undefined);
|
|
}
|
|
|
|
public override bool Equals(object obj)
|
|
{
|
|
if (ReferenceEquals(null, obj)) return false;
|
|
return obj is YogaValue && Equals((YogaValue) obj);
|
|
}
|
|
|
|
public override int GetHashCode()
|
|
{
|
|
unchecked
|
|
{
|
|
return (Value.GetHashCode() * 397) ^ (int) Unit;
|
|
}
|
|
}
|
|
|
|
public static YogaValue Undefined()
|
|
{
|
|
return new YogaValue
|
|
{
|
|
value = YogaConstants.Undefined,
|
|
unit = YogaUnit.Undefined
|
|
};
|
|
}
|
|
|
|
public static YogaValue Auto()
|
|
{
|
|
return new YogaValue
|
|
{
|
|
value = 0f,
|
|
unit = YogaUnit.Auto
|
|
};
|
|
}
|
|
|
|
public static YogaValue Percent(float value)
|
|
{
|
|
return new YogaValue
|
|
{
|
|
value = value,
|
|
unit = YogaConstants.IsUndefined(value) ? YogaUnit.Undefined : YogaUnit.Percent
|
|
};
|
|
}
|
|
|
|
public static implicit operator YogaValue(float pointValue)
|
|
{
|
|
return Point(pointValue);
|
|
}
|
|
|
|
#if WINDOWS_UWP_ARM
|
|
internal static YogaValue MarshalValue(IntPtr ptr)
|
|
{
|
|
return Marshal.PtrToStructure<YogaValue>(ptr);
|
|
}
|
|
#else
|
|
internal static YogaValue MarshalValue(YogaValue value)
|
|
{
|
|
return value;
|
|
}
|
|
#endif
|
|
}
|
|
}
|