Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1369 X-link: https://github.com/facebook/react-native/pull/39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49130714 fbshipit-source-id: 4305f8882d89f296e45b78497a51716a0dbb3b2d
74 lines
1.8 KiB
C++
74 lines
1.8 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
// @Generated by gentest/gentest.rb from gentest/fixtures/YGDisplayTest.html
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
#include <yoga/config/Config.h>
|
|
#include <yoga/node/Node.h>
|
|
|
|
#include <functional>
|
|
#include <memory>
|
|
|
|
using namespace facebook;
|
|
|
|
struct ConfigCloningTest : public ::testing::Test {
|
|
std::unique_ptr<yoga::Config, std::function<void(yoga::Config*)>> config;
|
|
void SetUp() override;
|
|
void TearDown() override;
|
|
|
|
static yoga::Node clonedNode;
|
|
static YGNodeRef cloneNode(YGNodeConstRef, YGNodeConstRef, int) {
|
|
return &clonedNode;
|
|
}
|
|
static YGNodeRef doNotClone(YGNodeConstRef, YGNodeConstRef, int) {
|
|
return nullptr;
|
|
}
|
|
};
|
|
|
|
TEST_F(ConfigCloningTest, uses_values_provided_by_cloning_callback) {
|
|
config->setCloneNodeCallback(cloneNode);
|
|
|
|
yoga::Node node{}, owner{};
|
|
auto clone = config->cloneNode(&node, &owner, 0, nullptr);
|
|
|
|
ASSERT_EQ(clone, &clonedNode);
|
|
}
|
|
|
|
TEST_F(
|
|
ConfigCloningTest,
|
|
falls_back_to_regular_cloning_if_callback_returns_null) {
|
|
config->setCloneNodeCallback(doNotClone);
|
|
|
|
yoga::Node node{}, owner{};
|
|
auto clone = config->cloneNode(&node, &owner, 0, nullptr);
|
|
|
|
ASSERT_NE(clone, nullptr);
|
|
YGNodeFree(clone);
|
|
}
|
|
|
|
TEST_F(ConfigCloningTest, can_clone_with_context) {
|
|
config->setCloneNodeCallback(
|
|
[](YGNodeConstRef, YGNodeConstRef, int, void* context) {
|
|
return (YGNodeRef) context;
|
|
});
|
|
|
|
yoga::Node node{}, owner{}, clone{};
|
|
ASSERT_EQ(config->cloneNode(&node, &owner, 0, &clone), &clone);
|
|
}
|
|
|
|
void ConfigCloningTest::SetUp() {
|
|
config = {static_cast<yoga::Config*>(YGConfigNew()), YGConfigFree};
|
|
}
|
|
|
|
void ConfigCloningTest::TearDown() {
|
|
config.reset();
|
|
}
|
|
|
|
yoga::Node ConfigCloningTest::clonedNode = {};
|