1813748eaa
Summary: Yoga's JavaScript bindings do not work past Node 10, or on recent versions of Ubuntu even using it. This is due to a reliance on `nbind`, a library which is no longer maintained. `nbind` itself abstracts over `embind` running Emscripten to generate an asm.js build, along with building Node native modules. In the meantime, [yoga-layout-prebuilt](https://www.npmjs.com/package/yoga-layout-prebuilt) has been used by the community instead of the official package. https://github.com/facebook/yoga/pull/1177 was contributed as a conversion of bindings created using `nbind` to instead use `embind` directly. I continued building on this to add more: 1. WebAssembly support (required to be async in browsers) 2. CMake + Ninja Build for the 4 flavors 3. TypeScript typings (partially generated) 4. yarn scripts to build (working on macOS, Ubuntu, Windows) 5. A README with some usage and contribution instructions 6. Updated tests to work with Jest, and updated general infra 7. ESLint and clang-format scripts 8. More GitHub actions (and now testing Windows) 9. Probably more I kinda got carried away here lol The plan is to eventually publish this to NPM, but there is a little bit of work after this before that happens. Pull Request resolved: https://github.com/facebook/yoga/pull/1177 Test Plan: The bindings pass Jest tests (both manual and generated). GitHub actions added for the different yarn scripts. Did some manual checks on using the library as TS. Reviewed By: christophpurrer Differential Revision: D42207782 Pulled By: NickGerleman fbshipit-source-id: 1dc5ce440f1c2b9705a005bbdcc86f952785d94e
123 lines
4.0 KiB
JavaScript
123 lines
4.0 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
test("align_baseline_parent_using_child_in_column_as_reference", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setFlexDirection(Yoga.FLEX_DIRECTION_ROW);
|
|
root.setWidth(1000);
|
|
root.setHeight(1000);
|
|
root.setAlignItems(Yoga.ALIGN_BASELINE);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child0.setWidth(500);
|
|
root_child0.setHeight(600);
|
|
root.insertChild(root_child0, 0);
|
|
|
|
const root_child1 = Yoga.Node.create(config);
|
|
root_child1.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child1.setWidth(500);
|
|
root_child1.setHeight(800);
|
|
root.insertChild(root_child1, 1);
|
|
|
|
const root_child1_child0 = Yoga.Node.create(config);
|
|
root_child1_child0.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child1_child0.setWidth(500);
|
|
root_child1_child0.setHeight(300);
|
|
root_child1.insertChild(root_child1_child0, 0);
|
|
|
|
const root_child1_child1 = Yoga.Node.create(config);
|
|
root_child1_child1.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child1_child1.setWidth(500);
|
|
root_child1_child1.setHeight(400);
|
|
root_child1_child1.setIsReferenceBaseline(true);
|
|
root_child1.insertChild(root_child1_child1, 1);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child0.getComputedTop()).toBe(100);
|
|
|
|
expect(root_child1.getComputedLeft()).toBe(500);
|
|
expect(root_child1.getComputedTop()).toBe(0);
|
|
|
|
expect(root_child1_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child1_child0.getComputedTop()).toBe(0);
|
|
|
|
expect(root_child1_child1.getComputedLeft()).toBe(0);
|
|
expect(root_child1_child1.getComputedTop()).toBe(300);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|
|
|
|
test("align_baseline_parent_using_child_in_row_as_reference", () => {
|
|
const config = Yoga.Config.create();
|
|
let root;
|
|
|
|
try {
|
|
root = Yoga.Node.create(config);
|
|
root.setFlexDirection(Yoga.FLEX_DIRECTION_ROW);
|
|
root.setWidth(1000);
|
|
root.setHeight(1000);
|
|
root.setAlignItems(Yoga.ALIGN_BASELINE);
|
|
|
|
const root_child0 = Yoga.Node.create(config);
|
|
root_child0.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child0.setWidth(500);
|
|
root_child0.setHeight(600);
|
|
root.insertChild(root_child0, 0);
|
|
|
|
const root_child1 = Yoga.Node.create(config);
|
|
root_child1.setFlexDirection(Yoga.FLEX_DIRECTION_ROW);
|
|
root_child1.setWidth(500);
|
|
root_child1.setHeight(800);
|
|
root.insertChild(root_child1, 1);
|
|
|
|
const root_child1_child0 = Yoga.Node.create(config);
|
|
root_child1_child0.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child1_child0.setWidth(500);
|
|
root_child1_child0.setHeight(500);
|
|
root_child1.insertChild(root_child1_child0, 0);
|
|
|
|
const root_child1_child1 = Yoga.Node.create(config);
|
|
root_child1_child1.setFlexDirection(Yoga.FLEX_DIRECTION_COLUMN);
|
|
root_child1_child1.setWidth(500);
|
|
root_child1_child1.setHeight(400);
|
|
root_child1_child1.setIsReferenceBaseline(true);
|
|
root_child1.insertChild(root_child1_child1, 1);
|
|
|
|
root.calculateLayout(Yoga.UNDEFINED, Yoga.UNDEFINED, Yoga.DIRECTION_LTR);
|
|
|
|
expect(root_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child0.getComputedTop()).toBe(0);
|
|
|
|
expect(root_child1.getComputedLeft()).toBe(500);
|
|
expect(root_child1.getComputedTop()).toBe(200);
|
|
|
|
expect(root_child1_child0.getComputedLeft()).toBe(0);
|
|
expect(root_child1_child0.getComputedTop()).toBe(0);
|
|
|
|
expect(root_child1_child1.getComputedLeft()).toBe(500);
|
|
expect(root_child1_child1.getComputedTop()).toBe(0);
|
|
} finally {
|
|
if (typeof root !== "undefined") {
|
|
root.freeRecursive();
|
|
}
|
|
|
|
config.free();
|
|
}
|
|
});
|