37a94a86de
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1809 X-link: https://github.com/facebook/react-native/pull/51181 We want to know if an artifact created during measurement can fully be reused after final layout, but the final layout is allowed to be slightly larger due to pixel grid rounding (while still allowing reuse). It's hard to tell after the fact, whether it is larger because of this rounding (though the measure is used), or if it may be a pixel larger for valid reasons. We can expose the unsnapped dimensions of a node to give us this information, and to correlate measurement artifacts. This is most of the time the same as the layout's measured dimension, though I don't think it's safe to use this, since anything else measuring the node after could clobber this (I think `YGNodeLayoutGetOverflow` may also be prone to this as a bug). Changelog: [Internal] Reviewed By: rshest Differential Revision: D74292949 fbshipit-source-id: 05011c66a9a9480544313eb1dfe2c46bf7742bac
184 lines
7.3 KiB
C++
184 lines
7.3 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
#include <cmath>
|
|
|
|
TEST(YogaTest, rounding_value) {
|
|
// Test that whole numbers are rounded to whole despite ceil/floor flags
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(6.000001, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(6.000001, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(6.000001, 2.0, false, true));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(5.999999, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(5.999999, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(5.999999, 2.0, false, true));
|
|
// Same tests for negative numbers
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-6.000001, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-6.000001, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-6.000001, 2.0, false, true));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-5.999999, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-5.999999, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-5.999999, 2.0, false, true));
|
|
|
|
// Test that numbers with fraction are rounded correctly accounting for
|
|
// ceil/floor flags
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(6.01, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(6.5, YGRoundValueToPixelGrid(6.01, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(6.01, 2.0, false, true));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(5.99, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(6.0, YGRoundValueToPixelGrid(5.99, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(5.5, YGRoundValueToPixelGrid(5.99, 2.0, false, true));
|
|
// Same tests for negative numbers
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-6.01, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-6.01, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(-6.5, YGRoundValueToPixelGrid(-6.01, 2.0, false, true));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-5.99, 2.0, false, false));
|
|
ASSERT_FLOAT_EQ(-5.5, YGRoundValueToPixelGrid(-5.99, 2.0, true, false));
|
|
ASSERT_FLOAT_EQ(-6.0, YGRoundValueToPixelGrid(-5.99, 2.0, false, true));
|
|
|
|
// Rounding up/down halfway values is as expected for both positive and
|
|
// negative numbers
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.5, 1.0, false, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.4, 1.0, false, false));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.6, 1.0, false, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.499999, 1.0, false, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.500001, 1.0, false, false));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.5001, 1.0, false, false));
|
|
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.5, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.4, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.6, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.499999, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.500001, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.5001, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.00001, 1.0, true, false));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3, 1.0, true, false));
|
|
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.5, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.4, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.6, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.499999, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.500001, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-4, YGRoundValueToPixelGrid(-3.5001, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3.00001, 1.0, false, true));
|
|
ASSERT_FLOAT_EQ(-3, YGRoundValueToPixelGrid(-3, 1.0, false, true));
|
|
|
|
// NAN is treated as expected:
|
|
ASSERT_TRUE(std::isnan(YGRoundValueToPixelGrid(
|
|
std::numeric_limits<double>::quiet_NaN(), 1.5, false, false)));
|
|
ASSERT_TRUE(std::isnan(YGRoundValueToPixelGrid(
|
|
1.5, std::numeric_limits<double>::quiet_NaN(), false, false)));
|
|
ASSERT_TRUE(std::isnan(YGRoundValueToPixelGrid(
|
|
std::numeric_limits<double>::quiet_NaN(),
|
|
std::numeric_limits<double>::quiet_NaN(),
|
|
false,
|
|
false)));
|
|
}
|
|
|
|
static YGSize measureText(
|
|
YGNodeConstRef /*node*/,
|
|
float /*width*/,
|
|
YGMeasureMode /*widthMode*/,
|
|
float /*height*/,
|
|
YGMeasureMode /*heightMode*/) {
|
|
return YGSize{10, 10};
|
|
}
|
|
|
|
// Regression test for https://github.com/facebook/yoga/issues/824
|
|
TEST(YogaTest, consistent_rounding_during_repeated_layouts) {
|
|
YGConfigRef config = YGConfigNew();
|
|
YGConfigSetPointScaleFactor(config, 2);
|
|
|
|
YGNodeRef root = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetMargin(root, YGEdgeTop, -1.49f);
|
|
YGNodeStyleSetWidth(root, 500);
|
|
YGNodeStyleSetHeight(root, 500);
|
|
|
|
YGNodeRef node0 = YGNodeNewWithConfig(config);
|
|
YGNodeInsertChild(root, node0, 0);
|
|
|
|
YGNodeRef node1 = YGNodeNewWithConfig(config);
|
|
YGNodeSetMeasureFunc(node1, measureText);
|
|
YGNodeInsertChild(node0, node1, 0);
|
|
|
|
for (int i = 0; i < 5; i++) {
|
|
// Dirty the tree so YGRoundToPixelGrid runs again
|
|
YGNodeStyleSetMargin(root, YGEdgeLeft, (float)(i + 1));
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(10, YGNodeLayoutGetHeight(node1));
|
|
}
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config);
|
|
}
|
|
|
|
TEST(YogaTest, per_node_point_scale_factor) {
|
|
YGConfigRef config1 = YGConfigNew();
|
|
YGConfigSetPointScaleFactor(config1, 2);
|
|
|
|
YGConfigRef config2 = YGConfigNew();
|
|
YGConfigSetPointScaleFactor(config2, 1);
|
|
|
|
YGConfigRef config3 = YGConfigNew();
|
|
YGConfigSetPointScaleFactor(config3, 0.5f);
|
|
|
|
YGNodeRef root = YGNodeNewWithConfig(config1);
|
|
YGNodeStyleSetWidth(root, 11.5);
|
|
YGNodeStyleSetHeight(root, 11.5);
|
|
|
|
YGNodeRef node0 = YGNodeNewWithConfig(config2);
|
|
YGNodeStyleSetWidth(node0, 9.5);
|
|
YGNodeStyleSetHeight(node0, 9.5);
|
|
YGNodeInsertChild(root, node0, 0);
|
|
|
|
YGNodeRef node1 = YGNodeNewWithConfig(config3);
|
|
YGNodeStyleSetWidth(node1, 7);
|
|
YGNodeStyleSetHeight(node1, 7);
|
|
YGNodeInsertChild(node0, node1, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(YGNodeLayoutGetWidth(root), 11.5);
|
|
ASSERT_EQ(YGNodeLayoutGetHeight(root), 11.5);
|
|
|
|
ASSERT_EQ(YGNodeLayoutGetWidth(node0), 10);
|
|
ASSERT_EQ(YGNodeLayoutGetHeight(node0), 10);
|
|
|
|
ASSERT_EQ(YGNodeLayoutGetWidth(node1), 8);
|
|
ASSERT_EQ(YGNodeLayoutGetHeight(node1), 8);
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config1);
|
|
YGConfigFree(config2);
|
|
YGConfigFree(config3);
|
|
}
|
|
|
|
TEST(YogaTest, raw_layout_dimensions) {
|
|
YGConfigRef config = YGConfigNew();
|
|
YGConfigSetPointScaleFactor(config, 0.5f);
|
|
|
|
YGNodeRef root = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(root, 11.5f);
|
|
YGNodeStyleSetHeight(root, 9.5f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(YGNodeLayoutGetWidth(root), 12.0f);
|
|
ASSERT_EQ(YGNodeLayoutGetHeight(root), 10.0f);
|
|
ASSERT_EQ(YGNodeLayoutGetRawWidth(root), 11.5f);
|
|
ASSERT_EQ(YGNodeLayoutGetRawHeight(root), 9.5f);
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config);
|
|
}
|