423dc155d8
Summary: X-link: https://github.com/facebook/react-native/pull/38303 Pull Request resolved: https://github.com/facebook/yoga/pull/1327 This bumps Yoga to C++ 17 for a few reasons: 1. New versions of C++ may introduce behavior changes (e.g. evaluation order) and deprecations. Keeping the version closer to the version of large users helps avoid that. 2. C++ 17 unblocks some new bits I have wanted to use at times, like `std::optional`, `std::variant`, `if constexpr`, `[[nodiscard]]`. 3. There are already changes in C++ 20 that would be directly useful to Yoga, like `std::bit_cast` to avoid `memcpy` style type punning. There has been some contention around C++ versions before, but by the time the next stable version of Yoga is out, it will have been more than 6 years (~2 C++ versions) since a stable version of Clang/LLVM with C++ 17 support. I would not like to go back further than n-2. Changelog: [Internal] Reviewed By: christophpurrer Differential Revision: D47383922 fbshipit-source-id: eb95d4853f2168b68d6df5fddb797236eac55870
75 lines
1.9 KiB
CMake
75 lines
1.9 KiB
CMake
# Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
#
|
|
# This source code is licensed under the MIT license found in the
|
|
# LICENSE file in the root directory of this source tree.
|
|
|
|
cmake_minimum_required(VERSION 3.13...3.26)
|
|
set(CMAKE_VERBOSE_MAKEFILE on)
|
|
project(yoga)
|
|
|
|
file(GLOB SOURCES CONFIGURE_DEPENDS
|
|
${CMAKE_CURRENT_SOURCE_DIR}/../yoga/*.cpp
|
|
${CMAKE_CURRENT_SOURCE_DIR}/../yoga/**/*.cpp
|
|
${CMAKE_CURRENT_SOURCE_DIR}/src/*.cpp)
|
|
|
|
include_directories(..)
|
|
|
|
set(CMAKE_CXX_STANDARD 17)
|
|
|
|
add_compile_definitions(
|
|
EMSCRIPTEN_HAS_UNBOUND_TYPE_NAMES=0)
|
|
|
|
set(COMPILE_OPTIONS
|
|
-flto
|
|
-fno-exceptions
|
|
-fno-rtti
|
|
-g0
|
|
-Os
|
|
"SHELL:-s STRICT=1")
|
|
|
|
add_compile_options(${COMPILE_OPTIONS})
|
|
|
|
add_link_options(
|
|
${COMPILE_OPTIONS}
|
|
--closure 1
|
|
--memory-init-file 0
|
|
--no-entry
|
|
"SHELL:-s ALLOW_MEMORY_GROWTH=1"
|
|
"SHELL:-s ASSERTIONS=0"
|
|
"SHELL:-s DYNAMIC_EXECUTION=0"
|
|
"SHELL:-s ENVIRONMENT='web,node'"
|
|
"SHELL:-s EXPORT_NAME='loadYoga'"
|
|
"SHELL:-s FETCH_SUPPORT_INDEXEDDB=0"
|
|
"SHELL:-s FILESYSTEM=0"
|
|
"SHELL:-s MALLOC='emmalloc'"
|
|
"SHELL:-s MODULARIZE=1"
|
|
"SHELL:-s TEXTDECODER=0")
|
|
|
|
link_libraries(embind)
|
|
|
|
add_library(yogaObjLib OBJECT ${SOURCES})
|
|
|
|
set(CMAKE_RUNTIME_OUTPUT_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}/binaries)
|
|
|
|
add_executable(asmjs-sync $<TARGET_OBJECTS:yogaObjLib>)
|
|
target_link_options(asmjs-sync PUBLIC
|
|
"SHELL:-s WASM=0"
|
|
"SHELL:-s WASM_ASYNC_COMPILATION=0")
|
|
|
|
add_executable(asmjs-async $<TARGET_OBJECTS:yogaObjLib>)
|
|
target_link_options(asmjs-async PUBLIC
|
|
"SHELL:-s WASM=0"
|
|
"SHELL:-s WASM_ASYNC_COMPILATION=1")
|
|
|
|
add_executable(wasm-sync $<TARGET_OBJECTS:yogaObjLib>)
|
|
target_link_options(wasm-sync PUBLIC
|
|
"SHELL:-s WASM=1"
|
|
"SHELL:-s SINGLE_FILE=1"
|
|
"SHELL:-s WASM_ASYNC_COMPILATION=0")
|
|
|
|
add_executable(wasm-async $<TARGET_OBJECTS:yogaObjLib>)
|
|
target_link_options(wasm-async PUBLIC
|
|
"SHELL:-s WASM=1"
|
|
"SHELL:-s SINGLE_FILE=1"
|
|
"SHELL:-s WASM_ASYNC_COMPILATION=1")
|