Summary: X-link: https://github.com/facebook/react-native/pull/42411 Pull Request resolved: https://github.com/facebook/yoga/pull/1562 I added a small regression D52605596, where negative border would not be correctly floored. This fixes that, and starts adding tests specifically targeting the computed style API, now decoupled from the yoga node. Reviewed By: joevilches Differential Revision: D52930827 fbshipit-source-id: e165dade705a8de54c92d65f3664c9081137788c
45 lines
1.3 KiB
C++
45 lines
1.3 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/style/Style.h>
|
|
|
|
namespace facebook::yoga {
|
|
|
|
TEST(Style, computed_padding_is_floored) {
|
|
yoga::Style style;
|
|
style.setPadding(Edge::All, value::points(-1.0f));
|
|
auto paddingStart = style.computeInlineStartPadding(
|
|
FlexDirection::Row, Direction::LTR, 0.0f /*widthSize*/);
|
|
ASSERT_EQ(paddingStart, 0.0f);
|
|
}
|
|
|
|
TEST(Style, computed_border_is_floored) {
|
|
yoga::Style style;
|
|
style.setBorder(Edge::All, value::points(-1.0f));
|
|
auto borderStart =
|
|
style.computeInlineStartBorder(FlexDirection::Row, Direction::LTR);
|
|
ASSERT_EQ(borderStart, 0.0f);
|
|
}
|
|
|
|
TEST(Style, computed_gap_is_floored) {
|
|
yoga::Style style;
|
|
style.setGap(Gutter::Column, value::points(-1.0f));
|
|
auto gapBetweenColumns = style.computeGapForAxis(FlexDirection::Row);
|
|
ASSERT_EQ(gapBetweenColumns, 0.0f);
|
|
}
|
|
|
|
TEST(Style, computed_margin_is_not_floored) {
|
|
yoga::Style style;
|
|
style.setMargin(Edge::All, value::points(-1.0f));
|
|
auto marginStart = style.computeInlineStartMargin(
|
|
FlexDirection::Row, Direction::LTR, 0.0f /*widthSize*/);
|
|
ASSERT_EQ(marginStart, -1.0f);
|
|
}
|
|
|
|
} // namespace facebook::yoga
|