b959c79a2a
Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
136 lines
4.4 KiB
C++
136 lines
4.4 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
using namespace ::testing;
|
|
|
|
class YogaTest_HadOverflowTests : public Test {
|
|
protected:
|
|
YogaTest_HadOverflowTests() : config(YGConfigNew()) {
|
|
root = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(root, 200);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionColumn);
|
|
YGNodeStyleSetFlexWrap(root, YGWrapNoWrap);
|
|
}
|
|
|
|
~YogaTest_HadOverflowTests() override {
|
|
YGNodeFreeRecursive(root);
|
|
YGConfigFree(config);
|
|
}
|
|
|
|
YGNodeRef root;
|
|
YGConfigRef config;
|
|
};
|
|
|
|
TEST_F(
|
|
YogaTest_HadOverflowTests,
|
|
children_overflow_no_wrap_and_no_flex_children) {
|
|
const YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 15);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
const YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(
|
|
YogaTest_HadOverflowTests,
|
|
spacing_overflow_no_wrap_and_no_flex_children) {
|
|
const YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
const YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, no_overflow_no_wrap_and_flex_children) {
|
|
const YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
const YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeStyleSetFlexShrink(child1, 1);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_FALSE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, hadOverflow_gets_reset_if_not_logger_valid) {
|
|
const YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
const YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
|
|
YGNodeStyleSetFlexShrink(child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_FALSE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, spacing_overflow_in_nested_nodes) {
|
|
const YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
const YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
const YGNodeRef child1_1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1_1, 80);
|
|
YGNodeStyleSetHeight(child1_1, 40);
|
|
YGNodeStyleSetMargin(child1_1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(child1, child1_1, 0);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|