Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
333 lines
10 KiB
C++
333 lines
10 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
struct _MeasureConstraint {
|
|
float width;
|
|
YGMeasureMode widthMode;
|
|
float height;
|
|
YGMeasureMode heightMode;
|
|
};
|
|
|
|
struct _MeasureConstraintList {
|
|
uint32_t length;
|
|
struct _MeasureConstraint* constraints;
|
|
};
|
|
|
|
static YGSize _measure(
|
|
YGNodeConstRef node,
|
|
float width,
|
|
YGMeasureMode widthMode,
|
|
float height,
|
|
YGMeasureMode heightMode) {
|
|
auto* constraintList = (struct _MeasureConstraintList*)YGNodeGetContext(node);
|
|
struct _MeasureConstraint* constraints = constraintList->constraints;
|
|
uint32_t currentIndex = constraintList->length;
|
|
(&constraints[currentIndex])->width = width;
|
|
(&constraints[currentIndex])->widthMode = widthMode;
|
|
(&constraints[currentIndex])->height = height;
|
|
(&constraints[currentIndex])->heightMode = heightMode;
|
|
constraintList->length = currentIndex + 1;
|
|
|
|
return YGSize{
|
|
widthMode == YGMeasureModeUndefined ? 10 : width,
|
|
heightMode == YGMeasureModeUndefined ? 10 : width,
|
|
};
|
|
}
|
|
|
|
TEST(YogaTest, exactly_measure_stretched_child_column) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].width);
|
|
ASSERT_EQ(YGMeasureModeExactly, constraintList.constraints[0].widthMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, exactly_measure_stretched_child_row) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeExactly, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, at_most_main_axis_column) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, at_most_cross_axis_column) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].width);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].widthMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, at_most_main_axis_row) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].width);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].widthMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, at_most_cross_axis_row) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, flex_child) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(root_child0, 1);
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(2u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].heightMode);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[1].height);
|
|
ASSERT_EQ(YGMeasureModeExactly, constraintList.constraints[1].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, flex_child_with_flex_basis) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(root_child0, 1);
|
|
YGNodeStyleSetFlexBasis(root_child0, 0);
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeExactly, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, overflow_scroll_column) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetOverflow(root, YGOverflowScroll);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].width);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].widthMode);
|
|
|
|
ASSERT_TRUE(YGFloatIsUndefined(constraintList.constraints[0].height));
|
|
ASSERT_EQ(YGMeasureModeUndefined, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, overflow_scroll_row) {
|
|
auto constraintList = _MeasureConstraintList{
|
|
0,
|
|
(struct _MeasureConstraint*)malloc(
|
|
10 * sizeof(struct _MeasureConstraint)),
|
|
};
|
|
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetOverflow(root, YGOverflowScroll);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeSetContext(root_child0, &constraintList);
|
|
YGNodeSetMeasureFunc(root_child0, _measure);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_EQ(1u, constraintList.length);
|
|
|
|
ASSERT_TRUE(YGFloatIsUndefined(constraintList.constraints[0].width));
|
|
ASSERT_EQ(YGMeasureModeUndefined, constraintList.constraints[0].widthMode);
|
|
|
|
ASSERT_FLOAT_EQ(100, constraintList.constraints[0].height);
|
|
ASSERT_EQ(YGMeasureModeAtMost, constraintList.constraints[0].heightMode);
|
|
|
|
free(constraintList.constraints);
|
|
YGNodeFreeRecursive(root);
|
|
}
|