26f2b28eca
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1369 X-link: https://github.com/facebook/react-native/pull/39370 This fixes const-correctness of callbacks (e.g. not letting a logger function modify nodes during layout). This helps us to continue to fix const-correctness issues inside of Yoga. This change is breaking to the public API, since it requires a change in signature passed to Yoga. Changelog: [Internal] Reviewed By: rshest Differential Revision: D49130714 fbshipit-source-id: 4305f8882d89f296e45b78497a51716a0dbb3b2d
252 lines
8.1 KiB
C++
252 lines
8.1 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
TEST(YogaTest, dirty_propagation) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
YGNodeStyleSetWidth(root_child0, 20);
|
|
|
|
EXPECT_TRUE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_TRUE(YGNodeIsDirty(root));
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_only_if_prop_changed) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_changing_layout_config) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
const YGNodeRef root_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0_child0, 25);
|
|
YGNodeStyleSetHeight(root_child0_child0, 20);
|
|
YGNodeInsertChild(root, root_child0_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0_child0));
|
|
|
|
YGConfigRef newConfig = YGConfigNew();
|
|
YGConfigSetErrata(newConfig, YGErrataStretchFlexBasis);
|
|
YGNodeSetConfig(root_child0, newConfig);
|
|
|
|
EXPECT_TRUE(YGNodeIsDirty(root));
|
|
EXPECT_TRUE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0_child0));
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0_child0));
|
|
|
|
YGConfigFree(newConfig);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_changing_benign_config) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
const YGNodeRef root_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0_child0, 25);
|
|
YGNodeStyleSetHeight(root_child0_child0, 20);
|
|
YGNodeInsertChild(root, root_child0_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0_child0));
|
|
|
|
YGConfigRef newConfig = YGConfigNew();
|
|
YGConfigSetLogger(
|
|
newConfig,
|
|
[](YGConfigConstRef, YGNodeConstRef, YGLogLevel, const char*, va_list) {
|
|
return 0;
|
|
});
|
|
YGNodeSetConfig(root_child0, newConfig);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child1));
|
|
EXPECT_FALSE(YGNodeIsDirty(root_child0_child0));
|
|
|
|
YGConfigFree(newConfig);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_mark_all_children_as_dirty_when_display_changes) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef child0 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(child0, 1);
|
|
const YGNodeRef child1 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(child1, 1);
|
|
|
|
const YGNodeRef child1_child0 = YGNodeNew();
|
|
const YGNodeRef child1_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(child1_child0_child0, 8);
|
|
YGNodeStyleSetHeight(child1_child0_child0, 16);
|
|
|
|
YGNodeInsertChild(child1_child0, child1_child0_child0, 0);
|
|
|
|
YGNodeInsertChild(child1, child1_child0, 0);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeInsertChild(root, child1, 0);
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayFlex);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayNone);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayNone);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayFlex);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(8, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(16, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayFlex);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayNone);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayNone);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayFlex);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(8, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(16, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_node_only_if_children_are_actually_removed) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 50);
|
|
YGNodeStyleSetHeight(root, 50);
|
|
|
|
const YGNodeRef child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(child0, 50);
|
|
YGNodeStyleSetHeight(child0, 25);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
const YGNodeRef child1 = YGNodeNew();
|
|
YGNodeRemoveChild(root, child1);
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
YGNodeFree(child1);
|
|
|
|
YGNodeRemoveChild(root, child0);
|
|
EXPECT_TRUE(YGNodeIsDirty(root));
|
|
YGNodeFree(child0);
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_node_only_if_undefined_values_gets_set_to_undefined) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetWidth(root, 50);
|
|
YGNodeStyleSetHeight(root, 50);
|
|
YGNodeStyleSetMinWidth(root, YGUndefined);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
|
|
YGNodeStyleSetMinWidth(root, YGUndefined);
|
|
|
|
EXPECT_FALSE(YGNodeIsDirty(root));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|