1813748eaa
Summary: Yoga's JavaScript bindings do not work past Node 10, or on recent versions of Ubuntu even using it. This is due to a reliance on `nbind`, a library which is no longer maintained. `nbind` itself abstracts over `embind` running Emscripten to generate an asm.js build, along with building Node native modules. In the meantime, [yoga-layout-prebuilt](https://www.npmjs.com/package/yoga-layout-prebuilt) has been used by the community instead of the official package. https://github.com/facebook/yoga/pull/1177 was contributed as a conversion of bindings created using `nbind` to instead use `embind` directly. I continued building on this to add more: 1. WebAssembly support (required to be async in browsers) 2. CMake + Ninja Build for the 4 flavors 3. TypeScript typings (partially generated) 4. yarn scripts to build (working on macOS, Ubuntu, Windows) 5. A README with some usage and contribution instructions 6. Updated tests to work with Jest, and updated general infra 7. ESLint and clang-format scripts 8. More GitHub actions (and now testing Windows) 9. Probably more I kinda got carried away here lol The plan is to eventually publish this to NPM, but there is a little bit of work after this before that happens. Pull Request resolved: https://github.com/facebook/yoga/pull/1177 Test Plan: The bindings pass Jest tests (both manual and generated). GitHub actions added for the different yarn scripts. Did some manual checks on using the library as TS. Reviewed By: christophpurrer Differential Revision: D42207782 Pulled By: NickGerleman fbshipit-source-id: 1dc5ce440f1c2b9705a005bbdcc86f952785d94e
55 lines
1.5 KiB
JavaScript
55 lines
1.5 KiB
JavaScript
/**
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*
|
|
* @format
|
|
*/
|
|
|
|
global.getMeasureCounter = function (Yoga, cb, staticWidth, staticHeight) {
|
|
let counter = 0;
|
|
|
|
return {
|
|
inc: function (width, widthMode, height, heightMode) {
|
|
counter += 1;
|
|
|
|
return cb
|
|
? cb(width, widthMode, height, heightMode)
|
|
: { width: staticWidth, height: staticHeight };
|
|
},
|
|
|
|
get: function () {
|
|
return counter;
|
|
},
|
|
};
|
|
};
|
|
|
|
global.getMeasureCounterMax = function (Yoga) {
|
|
return getMeasureCounter(Yoga, (width, widthMode, height, heightMode) => {
|
|
const measuredWidth =
|
|
widthMode === Yoga.MEASURE_MODE_UNDEFINED ? 10 : width;
|
|
const measuredHeight =
|
|
heightMode === Yoga.MEASURE_MODE_UNDEFINED ? 10 : height;
|
|
|
|
return { width: measuredWidth, height: measuredHeight };
|
|
});
|
|
};
|
|
|
|
global.getMeasureCounterMin = function (Yoga) {
|
|
return getMeasureCounter(Yoga, (width, widthMode, height, heightMode) => {
|
|
const measuredWidth =
|
|
widthMode === Yoga.MEASURE_MODE_UNDEFINED ||
|
|
(widthMode == Yoga.MEASURE_MODE_AT_MOST && width > 10)
|
|
? 10
|
|
: width;
|
|
const measuredHeight =
|
|
heightMode === Yoga.MEASURE_MODE_UNDEFINED ||
|
|
(heightMode == Yoga.MEASURE_MODE_AT_MOST && height > 10)
|
|
? 10
|
|
: height;
|
|
|
|
return { width: measuredWidth, height: measuredHeight };
|
|
});
|
|
};
|