DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity
Files
a38ec3d7a493c5497016d4d1b4e05b89cf5d6f65
yoga/java/tests/com/facebook/yoga
History
Amir Shalem a93e5d63c9 Don't call config->setLogger(nullptr) directly to avoid having no logger at all 
Summary:
Changelog: [Internal][Yoga] Don't call config->setLogger(nullptr) directly to avoid having no logger at all

Broken in D14151037 (05f36a835a) when it started calling
```
config->setLogger(nullptr);
```
instead of going thru
```
YGConfigSetLogger(config, nullptr);
```
which does the right thing by setting the logger to its default value:
https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/yoga/yoga/Yoga.cpp?commit=835911317e8b3cf7da1866e40e1c79cda0690136&lines=4320-4330

Also by default YogaConfig always have a logger:
https://www.internalfb.com/intern/diffusion/FBS/browsefile/master/xplat/yoga/yoga/Yoga.cpp?commit=835911317e8b3cf7da1866e40e1c79cda0690136&lines=335-343

Reviewed By: SidharthGuglani

Differential Revision: D22387459

fbshipit-source-id: 4da91da87a696d38cc9d8db2acb5845d29398adb
2020-07-06 03:53:19 -07:00
..
TestParametrization.java
Remove useVanillaJNI flag and usage of fbjni in yoga build
2019-11-13 15:16:37 -08:00
YGAbsolutePositionTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGAlignBaselineTest.java
Tidy up license headers
2019-10-15 10:36:38 -07:00
YGAlignContentTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGAlignItemsTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGAlignSelfTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGAndroidNewsFeed.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGBorderTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGDimensionTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGDisplayTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGFlexDirectionTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGFlexTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGFlexWrapTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGJustifyContentTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGMarginTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGMinMaxDimensionTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGPaddingTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGPercentageTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGRoundingTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YGSizeOverflowTest.java
Switch to YogaConfigFactory.create
2019-09-17 07:15:23 -07:00
YogaExceptionTest.java
Add exception handling in vanilla jni
2019-10-22 11:01:00 -07:00
YogaLoggerTest.java
Don't call config->setLogger(nullptr) directly to avoid having no logger at all
2020-07-06 03:53:19 -07:00
YogaNodeStylePropertiesTest.java
Tidy up license headers
2019-10-15 10:36:38 -07:00
YogaNodeTest.java
Tidy up license headers
2019-10-15 10:36:38 -07:00
YogaValueTest.java
Tidy up license headers
2019-10-15 10:36:38 -07:00