97c8bbde12
Summary: `JNIEnv`'s `FindClass(..)` function takes the classes in the standard `foo/bar/Baz` class specification (unless they're special, like arrays). Specifying them with `Lfoo/bar/Baz;` results in a `ClassNotFoundException` being raised -- which is especially unhelpful when intending to re-throw an exception. The docs for `JNIEnv#FindClass(..)` can be found [here][jnienv]. [jnienv]: https://docs.oracle.com/javase/7/docs/technotes/guides/jni/spec/functions.html#:~:text=The%20name%20argument,java/lang/String%22 ## Changelog [Android] [Fixed] - Correctly resolve classes with FindClass(..) X-link: https://github.com/facebook/react-native/pull/34533 Reviewed By: amir-shalem Differential Revision: D39133326 Pulled By: jacdebug fbshipit-source-id: 86283b7d21aed49ed0e9027b2aef85f0108cdf9a
53 lines
1.5 KiB
C++
53 lines
1.5 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <stdexcept>
|
|
#include <string>
|
|
#include "YogaJniException.h"
|
|
#include "common.h"
|
|
|
|
namespace facebook {
|
|
namespace yoga {
|
|
namespace vanillajni {
|
|
|
|
YogaJniException::YogaJniException() {
|
|
jclass cl = getCurrentEnv()->FindClass("java/lang/RuntimeException");
|
|
static const jmethodID methodId = facebook::yoga::vanillajni::getMethodId(
|
|
getCurrentEnv(), cl, "<init>", "()V");
|
|
auto throwable = getCurrentEnv()->NewObject(cl, methodId);
|
|
throwable_ =
|
|
newGlobalRef(getCurrentEnv(), static_cast<jthrowable>(throwable));
|
|
}
|
|
|
|
YogaJniException::YogaJniException(jthrowable throwable) {
|
|
throwable_ = newGlobalRef(getCurrentEnv(), throwable);
|
|
}
|
|
|
|
YogaJniException::YogaJniException(YogaJniException&& rhs)
|
|
: throwable_(std::move(rhs.throwable_)) {}
|
|
|
|
YogaJniException::YogaJniException(const YogaJniException& rhs) {
|
|
throwable_ = newGlobalRef(getCurrentEnv(), rhs.throwable_.get());
|
|
}
|
|
|
|
YogaJniException::~YogaJniException() {
|
|
try {
|
|
throwable_.reset();
|
|
} catch (...) {
|
|
std::terminate();
|
|
}
|
|
}
|
|
|
|
ScopedLocalRef<jthrowable> YogaJniException::getThrowable() const noexcept {
|
|
return make_local_ref(
|
|
getCurrentEnv(),
|
|
static_cast<jthrowable>(getCurrentEnv()->NewLocalRef(throwable_.get())));
|
|
}
|
|
} // namespace vanillajni
|
|
} // namespace yoga
|
|
} // namespace facebook
|