Summary: When an absolutely positioned node appeared inside an overflow:hidden parent, we were limiting its height. This is inconsistent with how layout behaves on the web. Closes https://github.com/facebook/css-layout/pull/218 Reviewed By: lucasr Differential Revision: D3797285 Pulled By: emilsjolander fbshipit-source-id: 98f98e77aa26edce86b9882c1cac284799b69a27
170 lines
7.0 KiB
C++
170 lines
7.0 KiB
C++
/**
|
|
* Copyright (c) 2014-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
/**
|
|
* @Generated by gentest/gentest.sh with the following input
|
|
*
|
|
* <div id="absolute_layout_width_height_left_top" style="width: 100px; height: 100px;">
|
|
* <div style="width:10px; height: 10px; position: absolute; left: 10px; top: 10px;"></div>
|
|
* </div>
|
|
* <div id="absolute_layout_width_height_right_bottom" style="width: 100px; height: 100px;">
|
|
* <div style="width:10px; height: 10px; position: absolute; right: 10px; bottom: 10px;"></div>
|
|
* </div>
|
|
* <div id="absolute_layout_left_top_right_bottom" style="width: 100px; height: 100px;">
|
|
* <div style="position: absolute; left: 10px; top: 10px; right: 10px; bottom: 10px;"></div>
|
|
* </div>
|
|
* <div id="absolute_layout_width_height_left_top_right_bottom" style="width: 100px; height: 100px;">
|
|
* <div style="width:10px; height: 10px; position: absolute; left: 10px; top: 10px; right: 10px; bottom: 10px;"></div>
|
|
* </div>
|
|
* <div id="do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent" style="height: 50px; width: 50px; overflow: hidden; flex-direction: row;">
|
|
* <div style="position: absolute; left: 0; top: 0;">
|
|
* <div style="width: 100px; height: 100px;"></div>
|
|
* </div>
|
|
* </div>
|
|
*
|
|
*/
|
|
|
|
#include <CSSLayout/CSSLayout.h>
|
|
#include <gtest/gtest.h>
|
|
|
|
TEST(CSSLayoutTest, absolute_layout_width_height_left_top) {
|
|
const CSSNodeRef root = CSSNodeNew();
|
|
CSSNodeStyleSetWidth(root, 100);
|
|
CSSNodeStyleSetHeight(root, 100);
|
|
|
|
const CSSNodeRef root_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeLeft, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeTop, 10);
|
|
CSSNodeStyleSetWidth(root_child0, 10);
|
|
CSSNodeStyleSetHeight(root_child0, 10);
|
|
CSSNodeInsertChild(root, root_child0, 0);
|
|
CSSNodeCalculateLayout(root, CSSUndefined, CSSUndefined, CSSDirectionLTR);
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root));
|
|
|
|
ASSERT_EQ(10, CSSNodeLayoutGetLeft(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetTop(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetWidth(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetHeight(root_child0));
|
|
}
|
|
|
|
TEST(CSSLayoutTest, absolute_layout_width_height_right_bottom) {
|
|
const CSSNodeRef root = CSSNodeNew();
|
|
CSSNodeStyleSetWidth(root, 100);
|
|
CSSNodeStyleSetHeight(root, 100);
|
|
|
|
const CSSNodeRef root_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeRight, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeBottom, 10);
|
|
CSSNodeStyleSetWidth(root_child0, 10);
|
|
CSSNodeStyleSetHeight(root_child0, 10);
|
|
CSSNodeInsertChild(root, root_child0, 0);
|
|
CSSNodeCalculateLayout(root, CSSUndefined, CSSUndefined, CSSDirectionLTR);
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root));
|
|
|
|
ASSERT_EQ(80, CSSNodeLayoutGetLeft(root_child0));
|
|
ASSERT_EQ(80, CSSNodeLayoutGetTop(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetWidth(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetHeight(root_child0));
|
|
}
|
|
|
|
TEST(CSSLayoutTest, absolute_layout_left_top_right_bottom) {
|
|
const CSSNodeRef root = CSSNodeNew();
|
|
CSSNodeStyleSetWidth(root, 100);
|
|
CSSNodeStyleSetHeight(root, 100);
|
|
|
|
const CSSNodeRef root_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeLeft, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeTop, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeRight, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeBottom, 10);
|
|
CSSNodeInsertChild(root, root_child0, 0);
|
|
CSSNodeCalculateLayout(root, CSSUndefined, CSSUndefined, CSSDirectionLTR);
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root));
|
|
|
|
ASSERT_EQ(10, CSSNodeLayoutGetLeft(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetTop(root_child0));
|
|
ASSERT_EQ(80, CSSNodeLayoutGetWidth(root_child0));
|
|
ASSERT_EQ(80, CSSNodeLayoutGetHeight(root_child0));
|
|
}
|
|
|
|
TEST(CSSLayoutTest, absolute_layout_width_height_left_top_right_bottom) {
|
|
const CSSNodeRef root = CSSNodeNew();
|
|
CSSNodeStyleSetWidth(root, 100);
|
|
CSSNodeStyleSetHeight(root, 100);
|
|
|
|
const CSSNodeRef root_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeLeft, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeTop, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeRight, 10);
|
|
CSSNodeStyleSetPosition(root_child0, CSSEdgeBottom, 10);
|
|
CSSNodeStyleSetWidth(root_child0, 10);
|
|
CSSNodeStyleSetHeight(root_child0, 10);
|
|
CSSNodeInsertChild(root, root_child0, 0);
|
|
CSSNodeCalculateLayout(root, CSSUndefined, CSSUndefined, CSSDirectionLTR);
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root));
|
|
|
|
ASSERT_EQ(10, CSSNodeLayoutGetLeft(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetTop(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetWidth(root_child0));
|
|
ASSERT_EQ(10, CSSNodeLayoutGetHeight(root_child0));
|
|
}
|
|
|
|
TEST(CSSLayoutTest, do_not_clamp_height_of_absolute_node_to_height_of_its_overflow_hidden_parent) {
|
|
const CSSNodeRef root = CSSNodeNew();
|
|
CSSNodeStyleSetFlexDirection(root, CSSFlexDirectionRow);
|
|
CSSNodeStyleSetOverflow(root, CSSOverflowHidden);
|
|
CSSNodeStyleSetWidth(root, 50);
|
|
CSSNodeStyleSetHeight(root, 50);
|
|
|
|
const CSSNodeRef root_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetPositionType(root_child0, CSSPositionTypeAbsolute);
|
|
CSSNodeInsertChild(root, root_child0, 0);
|
|
|
|
const CSSNodeRef root_child0_child0 = CSSNodeNew();
|
|
CSSNodeStyleSetWidth(root_child0_child0, 100);
|
|
CSSNodeStyleSetHeight(root_child0_child0, 100);
|
|
CSSNodeInsertChild(root_child0, root_child0_child0, 0);
|
|
CSSNodeCalculateLayout(root, CSSUndefined, CSSUndefined, CSSDirectionLTR);
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root));
|
|
ASSERT_EQ(50, CSSNodeLayoutGetWidth(root));
|
|
ASSERT_EQ(50, CSSNodeLayoutGetHeight(root));
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root_child0));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root_child0));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root_child0));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root_child0));
|
|
|
|
ASSERT_EQ(0, CSSNodeLayoutGetLeft(root_child0_child0));
|
|
ASSERT_EQ(0, CSSNodeLayoutGetTop(root_child0_child0));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetWidth(root_child0_child0));
|
|
ASSERT_EQ(100, CSSNodeLayoutGetHeight(root_child0_child0));
|
|
}
|