b8126cdc6c
Summary: X-link: https://github.com/facebook/react-native/pull/37207 Pull Request resolved: https://github.com/facebook/yoga/pull/1274 Yoga exposes public APIs for dirtying Nodes, but will itself perform dirty marking when changing bits which invalidate layout. E.g. changing the style of a Node will invalidate it along with every parent Node. Because config setting is newly public to the C ABI, this makes a similar change so that replacing a Node's config will dirty the tree above the node if there is a layout impacting config change (I don't think children need to be invalidated since child output shouldn't change given the same owner dimensions). One quirk of this is that configs may be changed independently of the node. So someone could attach a config to a Node, then change the live config after the fact. The config does not currently have a back pointer to the Node, so we do not invalidate in that case of live config edits. The future work to rectify this would be to make configs immutable once created. There are also currently some experimental features here which should maybe be compared, but these should be moved to YGErrata anyway. Reviewed By: javache Differential Revision: D45505089 fbshipit-source-id: 72b2b84ba758679af081d92e7403750c9cc53cb5
253 lines
8.0 KiB
C++
253 lines
8.0 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/YGNode.h>
|
|
|
|
TEST(YogaTest, dirty_propagation) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
YGNodeStyleSetWidth(root_child0, 20);
|
|
|
|
EXPECT_TRUE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_TRUE(root->isDirty());
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root->isDirty());
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_only_if_prop_changed) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root->isDirty());
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_changing_layout_config) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
const YGNodeRef root_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0_child0, 25);
|
|
YGNodeStyleSetHeight(root_child0_child0, 20);
|
|
YGNodeInsertChild(root, root_child0_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root_child0_child0->isDirty());
|
|
|
|
YGConfigRef newConfig = YGConfigNew();
|
|
YGConfigSetErrata(newConfig, YGErrataStretchFlexBasis);
|
|
YGNodeSetConfig(root_child0, newConfig);
|
|
|
|
EXPECT_TRUE(root->isDirty());
|
|
EXPECT_TRUE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root_child0_child0->isDirty());
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root_child0_child0->isDirty());
|
|
|
|
YGConfigFree(newConfig);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_propagation_changing_benign_config) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 100);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0, 50);
|
|
YGNodeStyleSetHeight(root_child0, 20);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
const YGNodeRef root_child1 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child1, 50);
|
|
YGNodeStyleSetHeight(root_child1, 20);
|
|
YGNodeInsertChild(root, root_child1, 1);
|
|
|
|
const YGNodeRef root_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(root_child0_child0, 25);
|
|
YGNodeStyleSetHeight(root_child0_child0, 20);
|
|
YGNodeInsertChild(root, root_child0_child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root_child0_child0->isDirty());
|
|
|
|
YGConfigRef newConfig = YGConfigNew();
|
|
YGConfigSetLogger(
|
|
newConfig,
|
|
[](const YGConfigRef, const YGNodeRef, YGLogLevel, const char*, va_list) {
|
|
return 0;
|
|
});
|
|
YGNodeSetConfig(root_child0, newConfig);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
EXPECT_FALSE(root_child0->isDirty());
|
|
EXPECT_FALSE(root_child1->isDirty());
|
|
EXPECT_FALSE(root_child0_child0->isDirty());
|
|
|
|
YGConfigFree(newConfig);
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_mark_all_children_as_dirty_when_display_changes) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionRow);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
|
|
const YGNodeRef child0 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(child0, 1);
|
|
const YGNodeRef child1 = YGNodeNew();
|
|
YGNodeStyleSetFlexGrow(child1, 1);
|
|
|
|
const YGNodeRef child1_child0 = YGNodeNew();
|
|
const YGNodeRef child1_child0_child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(child1_child0_child0, 8);
|
|
YGNodeStyleSetHeight(child1_child0_child0, 16);
|
|
|
|
YGNodeInsertChild(child1_child0, child1_child0_child0, 0);
|
|
|
|
YGNodeInsertChild(child1, child1_child0, 0);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeInsertChild(root, child1, 0);
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayFlex);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayNone);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayNone);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayFlex);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(8, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(16, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayFlex);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayNone);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(0, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeStyleSetDisplay(child0, YGDisplayNone);
|
|
YGNodeStyleSetDisplay(child1, YGDisplayFlex);
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
ASSERT_FLOAT_EQ(8, YGNodeLayoutGetWidth(child1_child0_child0));
|
|
ASSERT_FLOAT_EQ(16, YGNodeLayoutGetHeight(child1_child0_child0));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_node_only_if_children_are_actually_removed) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetAlignItems(root, YGAlignFlexStart);
|
|
YGNodeStyleSetWidth(root, 50);
|
|
YGNodeStyleSetHeight(root, 50);
|
|
|
|
const YGNodeRef child0 = YGNodeNew();
|
|
YGNodeStyleSetWidth(child0, 50);
|
|
YGNodeStyleSetHeight(child0, 25);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
const YGNodeRef child1 = YGNodeNew();
|
|
YGNodeRemoveChild(root, child1);
|
|
EXPECT_FALSE(root->isDirty());
|
|
YGNodeFree(child1);
|
|
|
|
YGNodeRemoveChild(root, child0);
|
|
EXPECT_TRUE(root->isDirty());
|
|
YGNodeFree(child0);
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|
|
|
|
TEST(YogaTest, dirty_node_only_if_undefined_values_gets_set_to_undefined) {
|
|
const YGNodeRef root = YGNodeNew();
|
|
YGNodeStyleSetWidth(root, 50);
|
|
YGNodeStyleSetHeight(root, 50);
|
|
YGNodeStyleSetMinWidth(root, YGUndefined);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
|
|
YGNodeStyleSetMinWidth(root, YGUndefined);
|
|
|
|
EXPECT_FALSE(root->isDirty());
|
|
|
|
YGNodeFreeRecursive(root);
|
|
}
|