Adam Comella 5c711a7076 When paddingStart is 0, it should override paddingHorizontal (#816) ...

Summary:
Fixes #815

Imagine a node with this style: `{ paddingHorizontal: 10, paddingStart: 0 }`.

After running layout on this node, we expect its computed `paddingStart` to be `0`. However, it is actually `10`.

Consider the expression `paddingEdgeStart.getValue() > 0.0f` in [`getLeadingPadding`](328ec7dc4d/yoga/YGNode.cpp (L461)). Why is `0` handled like a negative number rather than a positive number? I suspect this should be `>=` so `0` is handled like the positive numbers (this is how `getTrailingPadding` works).

It looks like 3a82d2b1a8 (diff-07b4949bf42749fde386e769ff08a124) changed the operator from `>=` to `>` in `getLeadingPadding`. I suspect it was a mistake. `getTrailingPadding` still uses `>=`.

I manually verified this using the code in #815 and added some unit tests to catch this bug and other similar issues.

Adam Comella
Microsoft Corp.
Pull Request resolved: https://github.com/facebook/yoga/pull/816

Reviewed By: priteshrnandgaonkar

Differential Revision: D10282617

Pulled By: shergin

fbshipit-source-id: 2ab2874ae39d9454308a020a960ace85573fe777

2018-10-12 15:08:18 -07:00

..

YGAbsolutePositionTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAlignBaselineTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAlignContentTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAlignItemsTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAlignSelfTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAndroidNewsFeed.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGAspectRatioTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGBaselineFuncTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGBorderTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGComputedMarginTest.cpp

When paddingStart is 0, it should override paddingHorizontal (#816)

2018-10-12 15:08:18 -07:00

YGComputedPaddingTest.cpp

When paddingStart is 0, it should override paddingHorizontal (#816)

2018-10-12 15:08:18 -07:00

YGDefaultValuesTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGDimensionTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGDirtiedTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGDirtyMarkingTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGDisplayTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGEdgeTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGFlexDirectionTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGFlexTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGFlexWrapTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGHadOverflowTest.cpp

Reset the hadOverflow flag at the beginning of the algorithm

2017-07-10 12:00:37 -07:00

YGInfiniteHeightTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGJustifyContentTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGLayoutDiffingTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGLoggerTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGMarginTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGMeasureCacheTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGMeasureModeTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGMeasureTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGMinMaxDimensionTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGNodeChildTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGPaddingTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGPercentageTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGPersistenceTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGRelayoutTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGRoundingFunctionTest.cpp

Fix rounding of negative numbers (#825)

2018-10-11 18:21:49 -07:00

YGRoundingMeasureFuncTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGRoundingTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGSizeOverflowTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGStyleTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGTraversalTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGTreeMutationTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00

YGZeroOutLayoutRecursivlyTest.cpp

Update copyright headers to yearless format

2018-09-11 15:53:35 -07:00