5009f5c1ac
Summary: Pull Request resolved: https://github.com/facebook/yoga/pull/1677 We have Clang Tidy warnings enabled internally, that will flag `const YG*Ref` as misleading, as a const pointer to non-const, instead of non-const pointer to const. Let's remove all the misleading const in existing tests, and generated tests. Reviewed By: joevilches Differential Revision: D59335968 fbshipit-source-id: c66af878904ba7900f8ffcd99162968d90f8e5c7
136 lines
4.3 KiB
C++
136 lines
4.3 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
using namespace ::testing;
|
|
|
|
class YogaTest_HadOverflowTests : public Test {
|
|
protected:
|
|
YogaTest_HadOverflowTests() : config(YGConfigNew()) {
|
|
root = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(root, 200);
|
|
YGNodeStyleSetHeight(root, 100);
|
|
YGNodeStyleSetFlexDirection(root, YGFlexDirectionColumn);
|
|
YGNodeStyleSetFlexWrap(root, YGWrapNoWrap);
|
|
}
|
|
|
|
~YogaTest_HadOverflowTests() override {
|
|
YGNodeFreeRecursive(root);
|
|
YGConfigFree(config);
|
|
}
|
|
|
|
YGNodeRef root;
|
|
YGConfigRef config;
|
|
};
|
|
|
|
TEST_F(
|
|
YogaTest_HadOverflowTests,
|
|
children_overflow_no_wrap_and_no_flex_children) {
|
|
YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 15);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(
|
|
YogaTest_HadOverflowTests,
|
|
spacing_overflow_no_wrap_and_no_flex_children) {
|
|
YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, no_overflow_no_wrap_and_flex_children) {
|
|
YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeStyleSetFlexShrink(child1, 1);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_FALSE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, hadOverflow_gets_reset_if_not_logger_valid) {
|
|
YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeStyleSetMargin(child1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
|
|
YGNodeStyleSetFlexShrink(child1, 1);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_FALSE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|
|
|
|
TEST_F(YogaTest_HadOverflowTests, spacing_overflow_in_nested_nodes) {
|
|
YGNodeRef child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child0, 80);
|
|
YGNodeStyleSetHeight(child0, 40);
|
|
YGNodeStyleSetMargin(child0, YGEdgeTop, 10);
|
|
YGNodeStyleSetMargin(child0, YGEdgeBottom, 10);
|
|
YGNodeInsertChild(root, child0, 0);
|
|
YGNodeRef child1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1, 80);
|
|
YGNodeStyleSetHeight(child1, 40);
|
|
YGNodeInsertChild(root, child1, 1);
|
|
YGNodeRef child1_1 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetWidth(child1_1, 80);
|
|
YGNodeStyleSetHeight(child1_1, 40);
|
|
YGNodeStyleSetMargin(child1_1, YGEdgeBottom, 5);
|
|
YGNodeInsertChild(child1, child1_1, 0);
|
|
|
|
YGNodeCalculateLayout(root, 200, 100, YGDirectionLTR);
|
|
|
|
ASSERT_TRUE(YGNodeLayoutGetHadOverflow(root));
|
|
}
|