b959c79a2a
Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
110 lines
3.3 KiB
C++
110 lines
3.3 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "common.h"
|
|
|
|
namespace facebook::yoga::vanillajni {
|
|
|
|
void registerNatives(
|
|
JNIEnv* env,
|
|
const char* className,
|
|
const JNINativeMethod methods[],
|
|
size_t numMethods) {
|
|
jclass clazz = env->FindClass(className);
|
|
|
|
assertNoPendingJniExceptionIf(env, clazz == nullptr);
|
|
|
|
auto result =
|
|
env->RegisterNatives(clazz, methods, static_cast<int32_t>(numMethods));
|
|
|
|
assertNoPendingJniExceptionIf(env, result != JNI_OK);
|
|
}
|
|
|
|
jmethodID getStaticMethodId(
|
|
JNIEnv* env,
|
|
jclass clazz,
|
|
const char* methodName,
|
|
const char* methodDescriptor) {
|
|
jmethodID methodId =
|
|
env->GetStaticMethodID(clazz, methodName, methodDescriptor);
|
|
assertNoPendingJniExceptionIf(env, methodId == nullptr);
|
|
return methodId;
|
|
}
|
|
|
|
jmethodID getMethodId(
|
|
JNIEnv* env,
|
|
jclass clazz,
|
|
const char* methodName,
|
|
const char* methodDescriptor) {
|
|
jmethodID methodId = env->GetMethodID(clazz, methodName, methodDescriptor);
|
|
assertNoPendingJniExceptionIf(env, methodId == nullptr);
|
|
return methodId;
|
|
}
|
|
|
|
jfieldID getFieldId(
|
|
JNIEnv* env,
|
|
jclass clazz,
|
|
const char* fieldName,
|
|
const char* fieldSignature) {
|
|
jfieldID fieldId = env->GetFieldID(clazz, fieldName, fieldSignature);
|
|
assertNoPendingJniExceptionIf(env, fieldId == nullptr);
|
|
return fieldId;
|
|
}
|
|
|
|
#define DEFINE_CALL_METHOD_FOR_PRIMITIVE_IMPLEMENTATION(jnitype, readableType) \
|
|
DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(jnitype, readableType) { \
|
|
va_list args; \
|
|
va_start(args, methodId); \
|
|
jnitype result = env->Call##readableType##MethodV(obj, methodId, args); \
|
|
va_end(args); \
|
|
assertNoPendingJniException(env); \
|
|
return result; \
|
|
}
|
|
|
|
DEFINE_CALL_METHOD_FOR_PRIMITIVE_IMPLEMENTATION(jlong, Long);
|
|
DEFINE_CALL_METHOD_FOR_PRIMITIVE_IMPLEMENTATION(jfloat, Float);
|
|
|
|
DEFINE_CALL_METHOD_FOR_PRIMITIVE_INTERFACE(void, Void) {
|
|
va_list args;
|
|
va_start(args, methodId);
|
|
env->CallVoidMethodV(obj, methodId, args);
|
|
va_end(args);
|
|
assertNoPendingJniException(env);
|
|
}
|
|
|
|
ScopedLocalRef<jobject>
|
|
callStaticObjectMethod(JNIEnv* env, jclass clazz, jmethodID methodId, ...) {
|
|
va_list args;
|
|
va_start(args, methodId);
|
|
jobject result = env->CallStaticObjectMethodV(clazz, methodId, args);
|
|
va_end(args);
|
|
assertNoPendingJniExceptionIf(env, result == nullptr);
|
|
return make_local_ref(env, result);
|
|
}
|
|
|
|
ScopedGlobalRef<jobject> newGlobalRef(JNIEnv* env, jobject obj) {
|
|
jobject result = env->NewGlobalRef(obj);
|
|
|
|
if (result == nullptr) {
|
|
logErrorMessageAndDie("Could not obtain global reference from object");
|
|
}
|
|
|
|
return make_global_ref(result);
|
|
}
|
|
|
|
ScopedGlobalRef<jthrowable> newGlobalRef(JNIEnv* env, jthrowable obj) {
|
|
auto result = static_cast<jthrowable>(env->NewGlobalRef(obj));
|
|
|
|
if (result == nullptr) {
|
|
logErrorMessageAndDie("Could not obtain global reference from object");
|
|
}
|
|
|
|
return make_global_ref(result);
|
|
}
|
|
|
|
} // namespace facebook::yoga::vanillajni
|