b959c79a2a
Summary: X-link: https://github.com/facebook/litho/pull/976 Pull Request resolved: https://github.com/facebook/yoga/pull/1586 X-link: https://github.com/facebook/react-native/pull/43299 Add the React Clang Tidy config to Yoga, run the auto fixes, and make some manual mechanical tweaks. Notably, the automatic changes to the infra for generating a Yoga tree from JSON capture make it 70% faster. Before: {F1463947076} After: {F1463946802} This also cleans up all the no-op shallow const parameters in headers. {F1463943386} Not all checks are available in all environments, but that is okay, as Clang Tidy will gracefully skip them. Changelog: [Internal] Reviewed By: sammy-SC Differential Revision: D54461054 fbshipit-source-id: dbd2d9ce51afd3174d1f2c6d439fa7d08baff46f
92 lines
2.1 KiB
C++
92 lines
2.1 KiB
C++
/*
|
|
* Copyright (c) Meta Platforms, Inc. and affiliates.
|
|
*
|
|
* This source code is licensed under the MIT license found in the
|
|
* LICENSE file in the root directory of this source tree.
|
|
*/
|
|
|
|
#include "corefunctions.h"
|
|
#include "YogaJniException.h"
|
|
#include "macros.h"
|
|
|
|
namespace facebook::yoga::vanillajni {
|
|
|
|
namespace {
|
|
JavaVM* globalVm = nullptr;
|
|
struct JavaVMInitializer {
|
|
explicit JavaVMInitializer(JavaVM* vm) {
|
|
if (!vm) {
|
|
logErrorMessageAndDie(
|
|
"You cannot pass a NULL JavaVM to ensureInitialized");
|
|
}
|
|
globalVm = vm;
|
|
}
|
|
};
|
|
} // namespace
|
|
|
|
jint ensureInitialized(JNIEnv** env, JavaVM* vm) {
|
|
static JavaVMInitializer init(vm);
|
|
|
|
if (env == nullptr) {
|
|
logErrorMessageAndDie(
|
|
"Need to pass a valid JNIEnv pointer to vanillajni initialization "
|
|
"routine");
|
|
}
|
|
|
|
if (vm->GetEnv(reinterpret_cast<void**>(env), JNI_VERSION_1_6) != JNI_OK) {
|
|
logErrorMessageAndDie(
|
|
"Error retrieving JNIEnv during initialization of vanillajni");
|
|
}
|
|
|
|
return JNI_VERSION_1_6;
|
|
}
|
|
|
|
// TODO why we need JNIEXPORT for getCurrentEnv ?
|
|
JNIEXPORT JNIEnv* getCurrentEnv() {
|
|
JNIEnv* env = nullptr;
|
|
jint ret = globalVm->GetEnv((void**)&env, JNI_VERSION_1_6);
|
|
if (ret != JNI_OK) {
|
|
logErrorMessageAndDie(
|
|
"There was an error retrieving the current JNIEnv. Make sure the "
|
|
"current thread is attached");
|
|
}
|
|
return env;
|
|
}
|
|
|
|
void logErrorMessageAndDie(const char* message) {
|
|
(void)message;
|
|
VANILLAJNI_LOG_ERROR(
|
|
"VanillaJni",
|
|
"Aborting due to error detected in native code: %s",
|
|
message);
|
|
VANILLAJNI_DIE();
|
|
}
|
|
|
|
void assertNoPendingJniException(JNIEnv* env) {
|
|
if (env->ExceptionCheck() == JNI_FALSE) {
|
|
return;
|
|
}
|
|
|
|
auto throwable = env->ExceptionOccurred();
|
|
if (throwable == nullptr) {
|
|
logErrorMessageAndDie("Unable to get pending JNI exception.");
|
|
}
|
|
env->ExceptionClear();
|
|
throw YogaJniException(throwable);
|
|
}
|
|
|
|
void assertNoPendingJniExceptionIf(JNIEnv* env, bool condition) {
|
|
if (!condition) {
|
|
return;
|
|
}
|
|
|
|
if (env->ExceptionCheck() == JNI_TRUE) {
|
|
assertNoPendingJniException(env);
|
|
return;
|
|
}
|
|
|
|
throw YogaJniException();
|
|
}
|
|
|
|
} // namespace facebook::yoga::vanillajni
|