24e2fc95dd
Summary: If we have a fractional measure output which matches the subpixel rounding factor, we still should round both dimension into the same direction. Fixes facebook/yoga#580. Closes https://github.com/facebook/yoga/pull/583 Reviewed By: marco-cova Differential Revision: D5274212 Pulled By: emilsjolander fbshipit-source-id: 1febf9194210437ab77f91319d10d4da9b284b79
132 lines
4.0 KiB
C++
132 lines
4.0 KiB
C++
/**
|
|
* Copyright (c) 2014-present, Facebook, Inc.
|
|
* All rights reserved.
|
|
*
|
|
* This source code is licensed under the BSD-style license found in the
|
|
* LICENSE file in the root directory of this source tree. An additional grant
|
|
* of patent rights can be found in the PATENTS file in the same directory.
|
|
*/
|
|
|
|
#include <gtest/gtest.h>
|
|
#include <yoga/Yoga.h>
|
|
|
|
static YGSize _measureFloor(YGNodeRef node,
|
|
float width,
|
|
YGMeasureMode widthMode,
|
|
float height,
|
|
YGMeasureMode heightMode) {
|
|
return YGSize{
|
|
width = 10.2f, height = 10.2f,
|
|
};
|
|
}
|
|
|
|
static YGSize _measureCeil(YGNodeRef node,
|
|
float width,
|
|
YGMeasureMode widthMode,
|
|
float height,
|
|
YGMeasureMode heightMode) {
|
|
return YGSize{
|
|
width = 10.5f, height = 10.5f,
|
|
};
|
|
}
|
|
|
|
static YGSize _measureFractial(YGNodeRef node,
|
|
float width,
|
|
YGMeasureMode widthMode,
|
|
float height,
|
|
YGMeasureMode heightMode) {
|
|
return YGSize{
|
|
width = 0.5f, height = 0.5f,
|
|
};
|
|
}
|
|
|
|
TEST(YogaTest, rounding_feature_with_custom_measure_func_floor) {
|
|
const YGConfigRef config = YGConfigNew();
|
|
const YGNodeRef root = YGNodeNewWithConfig(config);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
|
|
YGNodeSetMeasureFunc(root_child0, _measureFloor);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGConfigSetPointScaleFactor(config, 0.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
|
|
|
|
ASSERT_FLOAT_EQ(10.2, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(10.2, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGConfigSetPointScaleFactor(config, 1.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_FLOAT_EQ(11, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(11, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGConfigSetPointScaleFactor(config, 2.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
|
|
|
|
ASSERT_FLOAT_EQ(10.5, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(10.5, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGConfigSetPointScaleFactor(config, 4.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_FLOAT_EQ(10.25, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(10.25, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGConfigSetPointScaleFactor(config, 1.0f / 3.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionRTL);
|
|
|
|
ASSERT_FLOAT_EQ(12.0, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(12.0, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config);
|
|
}
|
|
|
|
TEST(YogaTest, rounding_feature_with_custom_measure_func_ceil) {
|
|
const YGConfigRef config = YGConfigNew();
|
|
const YGNodeRef root = YGNodeNewWithConfig(config);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
|
|
YGNodeSetMeasureFunc(root_child0, _measureCeil);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGConfigSetPointScaleFactor(config, 1.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_FLOAT_EQ(11, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(11, YGNodeLayoutGetHeight(root_child0));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config);
|
|
}
|
|
|
|
TEST(YogaTest, rounding_feature_with_custom_measure_and_fractial_matching_scale) {
|
|
const YGConfigRef config = YGConfigNew();
|
|
const YGNodeRef root = YGNodeNewWithConfig(config);
|
|
|
|
const YGNodeRef root_child0 = YGNodeNewWithConfig(config);
|
|
YGNodeStyleSetPosition(root_child0, YGEdgeLeft, 73.625);
|
|
YGNodeSetMeasureFunc(root_child0, _measureFractial);
|
|
YGNodeInsertChild(root, root_child0, 0);
|
|
|
|
YGConfigSetPointScaleFactor(config, 2.0f);
|
|
|
|
YGNodeCalculateLayout(root, YGUndefined, YGUndefined, YGDirectionLTR);
|
|
|
|
ASSERT_FLOAT_EQ(0.5, YGNodeLayoutGetWidth(root_child0));
|
|
ASSERT_FLOAT_EQ(0.5, YGNodeLayoutGetHeight(root_child0));
|
|
ASSERT_FLOAT_EQ(73.5, YGNodeLayoutGetLeft(root_child0));
|
|
|
|
YGNodeFreeRecursive(root);
|
|
|
|
YGConfigFree(config);
|
|
}
|