DaddyFrosty/yoga
1
0
Fork 0
Code Issues 96 Pull Requests 31 Actions Packages Projects Releases 33 Wiki Activity

Make gentest-validate more graceful of different file organization (#1672)

Browse Source 
Summary:
Pull Request resolved: https://github.com/facebook/yoga/pull/1672

`gentest-validate` checks signedsource for generated tests. D58307002 adds a new directory under `java/tests/com/facebook/yoga/`, which [confuses](https://github.com/facebook/yoga/actions/runs/9653979292/job/26627690870) the current directory traversal logic.

This replaces the traversal with `glob`, and makes us skip files without a signature, instead of special-casing the Java directory.

Reviewed By: yungsters

Differential Revision: D58987293

fbshipit-source-id: a5640f5faee4aa40879c266211c5e736a0b077be
This commit is contained in:
Nick Gerleman
2024-06-26 01:24:08 -07:00
committed by Facebook GitHub Bot
parent 53e4421178
commit 0888b20098
7 changed files with 116 additions and 60 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
javascript/just.config.cjs
View File

@@ -23,7 +23,7 @@ const {
const {existsSync} = require('fs');
const {readFile, writeFile, rm} = require('fs/promises');
const glob = require('glob');
const {glob} = require('glob');
const path = require('path');
const which = require('which');